Re: [HACKERS] Patch to include c.h

2012-09-17 Thread Gurjeet Singh
On Sun, Sep 16, 2012 at 11:52 AM, Tom Lane wrote: > Gurjeet Singh writes: > > I noticed that xlog.h uses PGDLLIMPORT, but it does not include c.h > > directly or indirectly. > > In general, all include files in Postgres assume that you've included > postgres.h or postgres_fe.h (as appropriate) f

Re: [HACKERS] Patch to include c.h

2012-09-16 Thread Tom Lane
Gurjeet Singh writes: > I noticed that xlog.h uses PGDLLIMPORT, but it does not include c.h > directly or indirectly. In general, all include files in Postgres assume that you've included postgres.h or postgres_fe.h (as appropriate) first; and practically all of them have far more dependencies on

[HACKERS] Patch to include c.h

2012-09-16 Thread Gurjeet Singh
I noticed that xlog.h uses PGDLLIMPORT, but it does not include c.h directly or indirectly. Also, in timestamp.h different code is enabled depending on HAVE_INT64_TMESTAMP being defined, but even though that macro is defined in pg_config.h, it does not automatically trickle down into this file, as