Re: [HACKERS] Patching dblink.c to avoid warning about open transaction

2005-09-28 Thread Jonathan Beit-Aharon
Joe Conway wrote: Bruce Momjian wrote: [ Joe, would you review this? ] Your patch has been added to the PostgreSQL unapplied patches list at: http://momjian.postgresql.org/cgi-bin/pgpatches It will be applied as soon as one of the PostgreSQL committers reviews and approves it. The pa

Re: [HACKERS] Patching dblink.c to avoid warning about open transaction

2005-09-26 Thread Joe Conway
Bruce Momjian wrote: [ Joe, would you review this? ] Your patch has been added to the PostgreSQL unapplied patches list at: http://momjian.postgresql.org/cgi-bin/pgpatches It will be applied as soon as one of the PostgreSQL committers reviews and approves it. The patch itself is pret

Re: [HACKERS] Patching dblink.c to avoid warning about open transaction

2005-09-26 Thread Bruce Momjian
[ Joe, would you review this? ] Your patch has been added to the PostgreSQL unapplied patches list at: http://momjian.postgresql.org/cgi-bin/pgpatches It will be applied as soon as one of the PostgreSQL committers reviews and approves it. ---

Re: [HACKERS] Patching dblink.c to avoid warning about open transaction

2005-09-23 Thread Bruce Momjian
Tom Lane wrote: > Jonathan Beit-Aharon <[EMAIL PROTECTED]> writes: > >     if (!conn) > >     > > DBLINK_CONN_NOT_AVAIL; > > Could we see this in a less broken format? Here is the patch in text format. -- Bruce Momjian| http://candle.pha.pa.us pgman

Re: [HACKERS] Patching dblink.c to avoid warning about open transaction

2005-09-23 Thread Tom Lane
Jonathan Beit-Aharon <[EMAIL PROTECTED]> writes: >     if (!conn) >     > DBLINK_CONN_NOT_AVAIL; > + > +   if (rcon) > +   > rcon->remoteTrFlag = (PQtransactionStatus(conn) != > PQTRANS_IDLE); > > -   res = PQexec(conn, "BEGIN"); > -   if (PQresultStatus(r

[HACKERS] Patching dblink.c to avoid warning about open transaction

2005-09-23 Thread Jonathan Beit-Aharon
Hi, I'm not a member of this list (yet), so please CC me on responses and discussion. The patch below seems to be completion of work already started, because the boolean remoteTrFlag was already defined, and all I had to add was its setting and two references. I hope someone will find it us