Re: [HACKERS] REGRESS_OPTS versus MSVC build scripts

2009-08-19 Thread Jeff Janes
> -- Forwarded message -- > From: David Fetter > To: Andrew Dunstan > Date: Tue, 18 Aug 2009 11:31:41 -0700 > Subject: Re: REGRESS_OPTS versus MSVC build scripts > On Tue, Aug 18, 2009 at 02:15:48PM -0400, Andrew Dunstan wrote: >> >> >> Andrew Dunstan wrote: >>> >> >> Here's an un

Re: [HACKERS] REGRESS_OPTS versus MSVC build scripts

2009-08-18 Thread Tom Lane
Andrew Dunstan writes: > David Fetter wrote: >> This section is probably better done with Tie::File. > You keep pushing that barrow. I ripped Tie::File OUT of the buildfarm - > it is not universally available. Besides, as the perl world says, TIMTOWTDI. Also, there's some value in having the co

Re: [HACKERS] REGRESS_OPTS versus MSVC build scripts

2009-08-18 Thread Andrew Dunstan
Alvaro Herrera wrote: Andrew Dunstan wrote: + sub fetchRegressOpts + { + my $handle; + open($handle," I think you should try GNUmakefile first, Makefile second. That's what gmake does. Hmm, ok. It doesn't matter much in the present case - none of the contrib modules a

Re: [HACKERS] REGRESS_OPTS versus MSVC build scripts

2009-08-18 Thread Andrew Dunstan
David Fetter wrote: + my $handle; + open($handle," This section is probably better done with Tie::File. You keep pushing that barrow. I ripped Tie::File OUT of the buildfarm - it is not universally available. Besides, as the perl world says, TIMTOWTDI. cheers andrew --

Re: [HACKERS] REGRESS_OPTS versus MSVC build scripts

2009-08-18 Thread Alvaro Herrera
Andrew Dunstan wrote: > + sub fetchRegressOpts > + { > + my $handle; > + open($handle," + || open($handle," + || die "Could not open Makefile"; I think you should try GNUmakefile first, Makefile second. That's what gmake does. -- Alvaro Herrera

Re: [HACKERS] REGRESS_OPTS versus MSVC build scripts

2009-08-18 Thread David Fetter
On Tue, Aug 18, 2009 at 02:15:48PM -0400, Andrew Dunstan wrote: > > > Andrew Dunstan wrote: >> >> >> Tom Lane wrote: >>> I believe (but won't be able to prove for another few hours) that the >>> reason the MSVC buildfarm members are failing on contrib/unaccent, >>> as seen here: >>> http://www.pg

Re: [HACKERS] REGRESS_OPTS versus MSVC build scripts

2009-08-18 Thread Andrew Dunstan
Andrew Dunstan wrote: Tom Lane wrote: I believe (but won't be able to prove for another few hours) that the reason the MSVC buildfarm members are failing on contrib/unaccent, as seen here: http://www.pgbuildfarm.org/cgi-bin/show_log.pl?nm=mastodon&dt=2009-08-18%2013:00:00 is that they are

Re: [HACKERS] REGRESS_OPTS versus MSVC build scripts

2009-08-18 Thread Andrew Dunstan
Tom Lane wrote: I believe (but won't be able to prove for another few hours) that the reason the MSVC buildfarm members are failing on contrib/unaccent, as seen here: http://www.pgbuildfarm.org/cgi-bin/show_log.pl?nm=mastodon&dt=2009-08-18%2013:00:00 is that they are not running the test in a U

[HACKERS] REGRESS_OPTS versus MSVC build scripts

2009-08-18 Thread Tom Lane
I believe (but won't be able to prove for another few hours) that the reason the MSVC buildfarm members are failing on contrib/unaccent, as seen here: http://www.pgbuildfarm.org/cgi-bin/show_log.pl?nm=mastodon&dt=2009-08-18%2013:00:00 is that they are not running the test in a UTF8-encoded database