Re: [HACKERS] RFC/WIP: adding new configuration options to TOAST

2015-11-04 Thread Craig Ringer
On 4 November 2015 at 20:48, Bill Moran wrote: > On a related note, since I've been digging in this area of code I feel > comfortable commenting that pluggable compression isn't terribly difficult > to implement. The most significant work will probably be in actually > implementing the various al

Re: [HACKERS] RFC/WIP: adding new configuration options to TOAST

2015-11-04 Thread Bill Moran
On Wed, 4 Nov 2015 13:07:09 +0800 Craig Ringer wrote: > On 4 November 2015 at 10:58, Bill Moran wrote: > > On Tue, 3 Nov 2015 18:34:39 -0800 > > Jeff Janes wrote: > > > >> On Tue, Nov 3, 2015 at 5:21 PM, Craig Ringer wrote: > >> > On 3 November 2015 at 23:04, Bill Moran wrote: > >> >> > >> >>

Re: [HACKERS] RFC/WIP: adding new configuration options to TOAST

2015-11-03 Thread Craig Ringer
On 4 November 2015 at 10:58, Bill Moran wrote: > On Tue, 3 Nov 2015 18:34:39 -0800 > Jeff Janes wrote: > >> On Tue, Nov 3, 2015 at 5:21 PM, Craig Ringer wrote: >> > On 3 November 2015 at 23:04, Bill Moran wrote: >> >> >> >> Looking for feedback to see if anyone sees any issues or has any >> >>

Re: [HACKERS] RFC/WIP: adding new configuration options to TOAST

2015-11-03 Thread Bill Moran
On Tue, 3 Nov 2015 18:34:39 -0800 Jeff Janes wrote: > On Tue, Nov 3, 2015 at 5:21 PM, Craig Ringer wrote: > > On 3 November 2015 at 23:04, Bill Moran wrote: > >> > >> Looking for feedback to see if anyone sees any issues or has any > >> suggestions on what I'm doing. The attached patch alters 3

Re: [HACKERS] RFC/WIP: adding new configuration options to TOAST

2015-11-03 Thread Jim Nasby
On 11/3/15 8:34 PM, Jeff Janes wrote: I currently have a table with one column which has a median width of 500 bytes, a 90th percentile of 650 bytes, and makes up 75% of the table's size, and the column is rarely used, while the table itself is frequently seq scanned. I'd very much like to drive

Re: [HACKERS] RFC/WIP: adding new configuration options to TOAST

2015-11-03 Thread Jeff Janes
On Tue, Nov 3, 2015 at 5:21 PM, Craig Ringer wrote: > On 3 November 2015 at 23:04, Bill Moran wrote: >> >> Looking for feedback to see if anyone sees any issues or has any >> suggestions on what I'm doing. The attached patch alters 3 things >> with regard to TOAST behavior: > > COMPRESSION_TEST_S

Re: [HACKERS] RFC/WIP: adding new configuration options to TOAST

2015-11-03 Thread Craig Ringer
On 3 November 2015 at 23:04, Bill Moran wrote: > > Looking for feedback to see if anyone sees any issues or has any > suggestions on what I'm doing. The attached patch alters 3 things > with regard to TOAST behavior: COMPRESSION_TEST_SIZE (2) seems useful. The other two mostly seem like options

[HACKERS] RFC/WIP: adding new configuration options to TOAST

2015-11-03 Thread Bill Moran
Looking for feedback to see if anyone sees any issues or has any suggestions on what I'm doing. The attached patch alters 3 things with regard to TOAST behavior: 1) Add a GUC target_compression_ratio: When attempting to compress a datum in the TOAST code, only stored the compressed version