Re: [HACKERS] Re: [COMMITTERS] pgsql: Add citext_pattern_ops for citext contrib module

2017-09-19 Thread Andrew Dunstan
On 09/19/2017 02:47 PM, Andrew Dunstan wrote: > > On 09/19/2017 11:11 AM, Tom Lane wrote: >> Andrew Dunstan writes: >>> This seems to have upset a number or animals in the buildfarm. >> Actually, after looking closer, my advice is just to drop the new >> test

Re: [HACKERS] Re: [COMMITTERS] pgsql: Add citext_pattern_ops for citext contrib module

2017-09-19 Thread Tom Lane
Andrew Dunstan writes: > On 09/19/2017 11:11 AM, Tom Lane wrote: >> Actually, after looking closer, my advice is just to drop the new >> test cases involving accented letters. It surprises me not in the >> least that those would have nonportable behavior:

Re: [HACKERS] Re: [COMMITTERS] pgsql: Add citext_pattern_ops for citext contrib module

2017-09-19 Thread Andrew Dunstan
On 09/19/2017 11:11 AM, Tom Lane wrote: > Andrew Dunstan writes: >> This seems to have upset a number or animals in the buildfarm. > Actually, after looking closer, my advice is just to drop the new > test cases involving accented letters. It surprises me not in

Re: [HACKERS] Re: [COMMITTERS] pgsql: Add citext_pattern_ops for citext contrib module

2017-09-19 Thread Tom Lane
Andrew Dunstan writes: > This seems to have upset a number or animals in the buildfarm. Actually, after looking closer, my advice is just to drop the new test cases involving accented letters. It surprises me not in the least that those would have nonportable

Re: [HACKERS] Re: [COMMITTERS] pgsql: Add citext_pattern_ops for citext contrib module

2017-09-19 Thread Tom Lane
Andrew Dunstan writes: > This seems to have upset a number or animals in the buildfarm. Looks like all the ones that are testing in en_US locale. > I could create a third output file, but I am seriously questioning the > point of all this, What locale did you

Re: [HACKERS] Re: [COMMITTERS] pgsql: Add citext_pattern_ops for citext contrib module

2017-09-19 Thread Simon Riggs
On 19 September 2017 at 15:22, Andrew Dunstan wrote: > > > On 09/19/2017 08:35 AM, Andrew Dunstan wrote: >> Add citext_pattern_ops for citext contrib module >> >> This is similar to text_pattern_ops. >> > > This seems to have upset a number or animals in the

[HACKERS] Re: [COMMITTERS] pgsql: Add citext_pattern_ops for citext contrib module

2017-09-19 Thread Andrew Dunstan
On 09/19/2017 08:35 AM, Andrew Dunstan wrote: > Add citext_pattern_ops for citext contrib module > > This is similar to text_pattern_ops. > This seems to have upset a number or animals in the buildfarm. I could create a third output file, but I am seriously questioning the point of all this,