Re: [HACKERS] Re: [COMMITTERS] pgsql: Remove outdated comments from the regression test files.

2010-11-29 Thread Heikki Linnakangas
On 28.11.2010 06:59, Robert Haas wrote: On Sat, Nov 27, 2010 at 3:46 PM, Tom Lanet...@sss.pgh.pa.us wrote: Robert Haasrobertmh...@gmail.com writes: On Nov 27, 2010, at 2:49 PM, Bruce Momjianbr...@momjian.us wrote: Who's going to be the first to say that being git-centric can't ever be a

Re: [HACKERS] Re: [COMMITTERS] pgsql: Remove outdated comments from the regression test files.

2010-11-29 Thread Magnus Hagander
On Mon, Nov 29, 2010 at 13:42, Heikki Linnakangas heikki.linnakan...@enterprisedb.com wrote: On 28.11.2010 06:59, Robert Haas wrote: On Sat, Nov 27, 2010 at 3:46 PM, Tom Lanet...@sss.pgh.pa.us  wrote: Robert Haasrobertmh...@gmail.com  writes: On Nov 27, 2010, at 2:49 PM, Bruce

Re: [HACKERS] Re: [COMMITTERS] pgsql: Remove outdated comments from the regression test files.

2010-11-29 Thread Robert Haas
On Mon, Nov 29, 2010 at 7:45 AM, Magnus Hagander mag...@hagander.net wrote: Let's do both: This fixes the bug introduced by the foobar patch from Sep 12th (git commitid a2c23897bc). I like to see the date of the referred patch in the commit message, to get an immediate idea of whether it was

Re: [HACKERS] Re: [COMMITTERS] pgsql: Remove outdated comments from the regression test files.

2010-11-29 Thread Magnus Hagander
On Mon, Nov 29, 2010 at 16:26, Robert Haas robertmh...@gmail.com wrote: On Mon, Nov 29, 2010 at 7:45 AM, Magnus Hagander mag...@hagander.net wrote: Let's do both: This fixes the bug introduced by the foobar patch from Sep 12th (git commitid a2c23897bc). I like to see the date of the referred

Re: [HACKERS] Re: [COMMITTERS] pgsql: Remove outdated comments from the regression test files.

2010-11-29 Thread Tom Lane
Magnus Hagander mag...@hagander.net writes: On Mon, Nov 29, 2010 at 16:26, Robert Haas robertmh...@gmail.com wrote: That works for me.  But should we make a practice of writing the ENTIRE SHA-ID rather than an abbreviated form, so that we could more easily replace 'em later if need be? I

Re: [HACKERS] Re: [COMMITTERS] pgsql: Remove outdated comments from the regression test files.

2010-11-29 Thread David Fetter
On Mon, Nov 29, 2010 at 02:09:29PM -0500, Tom Lane wrote: Magnus Hagander mag...@hagander.net writes: On Mon, Nov 29, 2010 at 16:26, Robert Haas robertmh...@gmail.com wrote: That works for me. �But should we make a practice of writing the ENTIRE SHA-ID rather than an abbreviated form, so

[HACKERS] Re: [COMMITTERS] pgsql: Remove outdated comments from the regression test files.

2010-11-27 Thread Bruce Momjian
Tom Lane wrote: Bruce Momjian br...@momjian.us writes: Robert Haas wrote: Remove outdated comments from the regression test files. Since 2004, int2 and int4 operators do detect overflow; this was fixed by commit 4171bb869f234281a13bb862d3b1e577bf336242. Extracted from a larger

[HACKERS] Re: [COMMITTERS] pgsql: Remove outdated comments from the regression test files.

2010-11-27 Thread Robert Haas
On Sat, Nov 27, 2010 at 3:46 PM, Tom Lane t...@sss.pgh.pa.us wrote: Robert Haas robertmh...@gmail.com writes: On Nov 27, 2010, at 2:49 PM, Bruce Momjian br...@momjian.us wrote: Who's going to be the first to say that being git-centric can't ever be a bad thing?  ;-) At least for me,