On 11.12.2012 21:11, Andres Freund wrote:
Now that I have read some of that code, I am currently unsure how the
current implementation of this can cooperate with translation, even when
used from the backend?
Hmm, there was a gettext() call missing from report_invalid_record.
That's where the
Heikki Linnakangas wrote:
On 11.12.2012 21:11, Andres Freund wrote:
Now that I have read some of that code, I am currently unsure how the
current implementation of this can cooperate with translation, even when
used from the backend?
Hmm, there was a gettext() call missing from
I've been molding this patch for a while now, here's what I have this
far (also available in my git repository).
The biggest change is in the error reporting. A stand-alone program that
wants to use xlogreader.c no longer has to provide a full-blown
replacement for ereport(). The only thing
On 2012-12-11 15:55:35 +0200, Heikki Linnakangas wrote:
I've been molding this patch for a while now, here's what I have this far
(also available in my git repository).
On a very quick this looks good. I will try to rebase the decoding stuff
and read a bit around in the course of that...
The
On 2012-12-11 15:44:39 +0100, Andres Freund wrote:
On 2012-12-11 15:55:35 +0200, Heikki Linnakangas wrote:
* It's pretty ugly that to use the rm_desc functions, you have to provide
dummy implementations of a bunch of backend functions, including pfree() and
timestamptz_to_str(). Should find
On 2012-12-11 16:43:12 +0100, Andres Freund wrote:
On 2012-12-11 15:44:39 +0100, Andres Freund wrote:
On 2012-12-11 15:55:35 +0200, Heikki Linnakangas wrote:
* It's pretty ugly that to use the rm_desc functions, you have to provide
dummy implementations of a bunch of backend functions,
On 2012-12-11 15:55:35 +0200, Heikki Linnakangas wrote:
I've been molding this patch for a while now, here's what I have this far
(also available in my git repository).
The biggest change is in the error reporting. A stand-alone program that
wants to use xlogreader.c no longer has to provide
On Tue, Dec 11, 2012 at 9:44 AM, Andres Freund and...@2ndquadrant.com wrote:
* How about we move pg_xlogdump to contrib? It doesn't feel like the kind of
essential tool that deserves to be in src/bin.
contrib would be fine, but I think src/bin is better. There have been
quite some bugs by now
Robert Haas robertmh...@gmail.com writes:
I think I'm with Heikki on this one. Dumping xlog data is useful, but
it's really for developers and troubleshooters, not something we
expect people to do on a regular basis, so contrib seems appropriate.
There are two downsides for contrib rather
Dimitri Fontaine dimi...@2ndquadrant.fr writes:
Robert Haas robertmh...@gmail.com writes:
I think I'm with Heikki on this one. Dumping xlog data is useful, but
it's really for developers and troubleshooters, not something we
expect people to do on a regular basis, so contrib seems
Tom Lane t...@sss.pgh.pa.us writes:
User trust, maybe, but the maintenance argument seems bogus.
We ship contrib on the same release schedule as core.
I meant maintenance as in updating the code when it needs to be, I'm not
sure contrib systematically receives the same careness as core. I have
On 11 December 2012 22:24, Tom Lane t...@sss.pgh.pa.us wrote:
TBH, I don't believe that ordinary users will need this tool at all,
ever, and thus I don't want it in src/bin/. From a packaging standpoint
it will be a lot easier if it's in contrib ... otherwise I'll probably
have to invent some
Peter Geoghegan pe...@2ndquadrant.com writes:
Perhaps people who live in countries with less bandwidth care about
these things more.
The day they will need it is not the day the bandwidth will magically
increase, is all I'm saying. Better have that around just in case you
get WAL corruption
On 2012-12-11 22:52:09 +, Peter Geoghegan wrote:
On 11 December 2012 22:24, Tom Lane t...@sss.pgh.pa.us wrote:
TBH, I don't believe that ordinary users will need this tool at all,
ever, and thus I don't want it in src/bin/. From a packaging standpoint
it will be a lot easier if it's in
(Offlist)
Just a quick note that I'm working on this patch now. I pushed some
trivial fixes to my git repository at
git://git.postgresql.org/git/users/heikki/postgres.git, xlogreader_v3
branch.
- Heikki
--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes
On 10.12.2012 22:22, Heikki Linnakangas wrote:
(Offlist)
Just a quick note that I'm working on this patch now. I pushed some
trivial fixes to my git repository at
git://git.postgresql.org/git/users/heikki/postgres.git, xlogreader_v3
branch.
Oops, wasn't offlist :-). Well, if anyone wants to
On 2012-11-15 16:22:56 +0200, Heikki Linnakangas wrote:
On 15.11.2012 03:17, Andres Freund wrote:
Features:
- streaming reading/writing
- filtering
- reassembly of records
Reusing the ReadRecord infrastructure in situations where the code that wants
to do so is not tightly integrated
On 2012-11-15 16:22:56 +0200, Heikki Linnakangas wrote:
On 15.11.2012 03:17, Andres Freund wrote:
Features:
- streaming reading/writing
- filtering
- reassembly of records
Reusing the ReadRecord infrastructure in situations where the code that wants
to do so is not tightly integrated
18 matches
Mail list logo
