Re: [BUGS] Re: [HACKERS] Re: BUG #9210: PostgreSQL string store bug? not enforce check with correct characterSET/encoding

2014-02-23 Thread Tom Lane
Noah Misch n...@leadboat.com writes: On Fri, Feb 21, 2014 at 05:20:06PM -0500, Tom Lane wrote: ... However, I think there's a case to be made for adding the additional pg_verify_mbstr() calls in the back branches. We've been promising since around 8.3 that invalidly encoded data can't get

Re: [HACKERS] Re: BUG #9210: PostgreSQL string store bug? not enforce check with correct characterSET/encoding

2014-02-21 Thread Tom Lane
Noah Misch n...@leadboat.com writes: On Wed, Feb 19, 2014 at 08:22:13PM -0500, Tom Lane wrote: How much of this is back-patch material, do you think? None of it. While many of the failures to validate against a character encoding are clear bugs, applications hum along in spite of such bugs

Re: [HACKERS] Re: BUG #9210: PostgreSQL string store bug? not enforce check with correct characterSET/encoding

2014-02-21 Thread Noah Misch
On Fri, Feb 21, 2014 at 05:20:06PM -0500, Tom Lane wrote: Noah Misch n...@leadboat.com writes: On Wed, Feb 19, 2014 at 08:22:13PM -0500, Tom Lane wrote: How much of this is back-patch material, do you think? None of it. While many of the failures to validate against a character

[HACKERS] Re: BUG #9210: PostgreSQL string store bug? not enforce check with correct characterSET/encoding

2014-02-19 Thread Noah Misch
On Wed, Feb 19, 2014 at 08:22:13PM -0500, Tom Lane wrote: The more I looked into mbutils.c, the less happy I got. The attached proposed patch takes care of the missing-verification hole in pg_do_encoding_conversion() and pg_server_to_any(), and also gets rid of what I believe to be obsolete