Re: [HACKERS] Re: pg_ctl wait exit code (was Re: [COMMITTERS] pgsql: Additional tests for subtransactions in recovery)

2017-07-05 Thread Michael Paquier
On Thu, Jul 6, 2017 at 2:41 AM, Peter Eisentraut wrote: > On 7/2/17 20:28, Michael Paquier wrote: >>> I was going to hold this back for PG11, but since we're now doing some >>> other tweaks in pg_ctl, it might be useful to add this too. Thoughts? >> >> The use of 0 as exit code for the new promot

Re: [HACKERS] Re: pg_ctl wait exit code (was Re: [COMMITTERS] pgsql: Additional tests for subtransactions in recovery)

2017-07-05 Thread Peter Eisentraut
On 7/2/17 20:28, Michael Paquier wrote: >> I was going to hold this back for PG11, but since we're now doing some >> other tweaks in pg_ctl, it might be useful to add this too. Thoughts? > > The use of 0 as exit code for the new promote -w if timeout is reached > looks like an open item to me. Cl

[HACKERS] Re: pg_ctl wait exit code (was Re: [COMMITTERS] pgsql: Additional tests for subtransactions in recovery)

2017-07-02 Thread Michael Paquier
On Sat, Jul 1, 2017 at 4:47 AM, Peter Eisentraut wrote: > On 5/1/17 12:19, Peter Eisentraut wrote: >> However: Failure to complete promotion within the waiting time does not >> lead to an error exit, so you will not get a failure if the promotion >> does not finish. This is probably a mistake. L

[HACKERS] Re: pg_ctl wait exit code (was Re: [COMMITTERS] pgsql: Additional tests for subtransactions in recovery)

2017-06-30 Thread Peter Eisentraut
On 5/1/17 12:19, Peter Eisentraut wrote: > On 4/27/17 08:41, Michael Paquier wrote: >> +$node_slave->promote; >> +$node_slave->poll_query_until('postgres', >> + "SELECT NOT pg_is_in_recovery()") >> + or die "Timed out while waiting for promotion of standby"; >> >> This reminds me that we should