Re: [HACKERS] RecordTransactionCommit() and SharedInvalidationMessages

2010-08-13 Thread Robert Haas
On Thu, Aug 12, 2010 at 9:43 PM, Fujii Masao wrote: > On Fri, Aug 13, 2010 at 10:24 AM, Robert Haas wrote: >> On Thu, Aug 12, 2010 at 12:11 AM, Fujii Masao wrote: >>> It appears to me that RecordTransactionCommit() only needs to WAL-log >>> shared invalidation messages when wal_level is

Re: [HACKERS] RecordTransactionCommit() and SharedInvalidationMessages

2010-08-12 Thread Fujii Masao
On Fri, Aug 13, 2010 at 10:24 AM, Robert Haas wrote: > On Thu, Aug 12, 2010 at 12:11 AM, Fujii Masao wrote: >> It appears to me that RecordTransactionCommit() only needs to WAL-log >> shared invalidation messages when wal_level is hot_standby, but I >> don't see a guard to prevent it

Re: [HACKERS] RecordTransactionCommit() and SharedInvalidationMessages

2010-08-12 Thread Robert Haas
On Thu, Aug 12, 2010 at 12:11 AM, Fujii Masao wrote: > It appears to me that RecordTransactionCommit() only needs to WAL-log > shared invalidation messages when wal_level is hot_standby, but I > don't see a guard to prevent it from doing it in all cases. [...] >>> The fix looks pretty

Re: [HACKERS] RecordTransactionCommit() and SharedInvalidationMessages

2010-08-11 Thread Fujii Masao
On Wed, Aug 11, 2010 at 11:35 PM, Heikki Linnakangas wrote: > On 11/08/10 16:46, Robert Haas wrote: >> >> On Wed, Aug 11, 2010 at 1:17 AM, Fujii Masao >>  wrote: >>> >>> On Tue, Aug 10, 2010 at 9:30 AM, Robert Haas >>>  wrote: It appears to me that RecordTransactionCommit() only needs to

Re: [HACKERS] RecordTransactionCommit() and SharedInvalidationMessages

2010-08-11 Thread Heikki Linnakangas
On 11/08/10 16:46, Robert Haas wrote: On Wed, Aug 11, 2010 at 1:17 AM, Fujii Masao wrote: On Tue, Aug 10, 2010 at 9:30 AM, Robert Haas wrote: It appears to me that RecordTransactionCommit() only needs to WAL-log shared invalidation messages when wal_level is hot_standby, but I don't see a gua

Re: [HACKERS] RecordTransactionCommit() and SharedInvalidationMessages

2010-08-11 Thread Robert Haas
On Wed, Aug 11, 2010 at 1:17 AM, Fujii Masao wrote: > On Tue, Aug 10, 2010 at 9:30 AM, Robert Haas wrote: >> It appears to me that RecordTransactionCommit() only needs to WAL-log >> shared invalidation messages when wal_level is hot_standby, but I >> don't see a guard to prevent it from doing it

Re: [HACKERS] RecordTransactionCommit() and SharedInvalidationMessages

2010-08-10 Thread Fujii Masao
On Tue, Aug 10, 2010 at 9:30 AM, Robert Haas wrote: > It appears to me that RecordTransactionCommit() only needs to WAL-log > shared invalidation messages when wal_level is hot_standby, but I > don't see a guard to prevent it from doing it in all cases. Perhaps right. During not hot standby, ther

[HACKERS] RecordTransactionCommit() and SharedInvalidationMessages

2010-08-09 Thread Robert Haas
It appears to me that RecordTransactionCommit() only needs to WAL-log shared invalidation messages when wal_level is hot_standby, but I don't see a guard to prevent it from doing it in all cases. Am I missing something? -- Robert Haas EnterpriseDB: http://www.enterprisedb.com The Enterprise Post