Re: [HACKERS] Redundant error messages in policy.c

2015-07-07 Thread Joe Conway
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 07/06/2015 02:26 PM, Stephen Frost wrote: > Daniele, > > * Daniele Varrazzo (daniele.varra...@gmail.com) wrote: >> There are 5 different strings (one has a whitespace error), they >> could be 2. Patch attached. > > Fair point. I did try to addre

Re: [HACKERS] Redundant error messages in policy.c

2015-07-06 Thread Stephen Frost
Daniele, * Daniele Varrazzo (daniele.varra...@gmail.com) wrote: > There are 5 different strings (one has a whitespace error), they could > be 2. Patch attached. Fair point. I did try to address the language around policy vs. row security vs. row level security, but didn't look as closely as I sh

[HACKERS] Redundant error messages in policy.c

2015-07-06 Thread Daniele Varrazzo
There are 5 different strings (one has a whitespace error), they could be 2. Patch attached. postgresql/src/backend$ grep errmsg commands/policy.c | grep policy | sed 's/^ *//' errmsg("policy \"%s\" for relation \"%s\" already exists", errmsg("policy \"%s\" on table \"%s\" does not exist", errm