Re: [HACKERS] Refactor to split nodeAgg.c?

2015-06-30 Thread David Rowley
On 30 June 2015 at 14:33, Jeff Davis wrote: > I was going to rebase my HashAgg patch, and got some conflicts related > to the grouping sets patch. I could probably sort them out, but I think > that may be the tipping point where we want to break up nodeAgg.c into > nodeSortedAgg.c and nodeHashAgg

Re: [HACKERS] Refactor to split nodeAgg.c?

2015-06-30 Thread Andres Freund
Hi, On 2015-06-29 19:33:58 -0700, Jeff Davis wrote: > I was going to rebase my HashAgg patch, and got some conflicts related > to the grouping sets patch. I could probably sort them out, but I think > that may be the tipping point where we want to break up nodeAgg.c into > nodeSortedAgg.c and node

Re: [HACKERS] Refactor to split nodeAgg.c?

2015-06-29 Thread Tom Lane
Jeff Davis writes: > I was going to rebase my HashAgg patch, and got some conflicts related > to the grouping sets patch. I could probably sort them out, but I think > that may be the tipping point where we want to break up nodeAgg.c into > nodeSortedAgg.c and nodeHashAgg.c, and probably a common

[HACKERS] Refactor to split nodeAgg.c?

2015-06-29 Thread Jeff Davis
I was going to rebase my HashAgg patch, and got some conflicts related to the grouping sets patch. I could probably sort them out, but I think that may be the tipping point where we want to break up nodeAgg.c into nodeSortedAgg.c and nodeHashAgg.c, and probably a common file as well. This would al