Re: [HACKERS] Refactoring log_newpage

2012-02-02 Thread Tom Lane
Simon Riggs writes: > On Wed, Feb 1, 2012 at 10:42 PM, Jim Nasby wrote: >> But we already had RelFileNode; wouldn't that be enough to tell what rmgr >> was responsible for the new page? Can 2 different rmgrs write to the same >> file node? > No, but which one? No way to tell unless you have fu

Re: [HACKERS] Refactoring log_newpage

2012-02-02 Thread Heikki Linnakangas
On 02.02.2012 11:35, Simon Riggs wrote: On Thu, Feb 2, 2012 at 7:26 AM, Heikki Linnakangas wrote: Well, you can obviously check the catalogs for that, but you must be assuming that you don't have access to the catalogs or this would be a non-issue. You can also identify the kind of page by l

Re: [HACKERS] Refactoring log_newpage

2012-02-02 Thread Simon Riggs
On Thu, Feb 2, 2012 at 7:26 AM, Heikki Linnakangas wrote: > Well, you can obviously check the catalogs for that, but you must be > assuming that you don't have access to the catalogs or this would be a > non-issue. > > You can also identify the kind of page by looking at the special area of the >

Re: [HACKERS] Refactoring log_newpage

2012-02-01 Thread Heikki Linnakangas
On 02.02.2012 08:19, Simon Riggs wrote: On Wed, Feb 1, 2012 at 10:42 PM, Jim Nasby wrote: On Feb 1, 2012, at 4:25 AM, Simon Riggs wrote: At present log_newpage() produces log records called XLOG_HEAP_NEWPAGE. That routine is used by HEAP, BTREE, GIN, SPGIST rmgrs, as well as various forks. W

Re: [HACKERS] Refactoring log_newpage

2012-02-01 Thread Simon Riggs
On Wed, Feb 1, 2012 at 10:42 PM, Jim Nasby wrote: > On Feb 1, 2012, at 4:25 AM, Simon Riggs wrote: >> At present log_newpage() produces log records called XLOG_HEAP_NEWPAGE. >> >> That routine is used by HEAP, BTREE, GIN, SPGIST rmgrs, as well as >> various forks. >> >> WAL contains no information

Re: [HACKERS] Refactoring log_newpage

2012-02-01 Thread Jim Nasby
On Feb 1, 2012, at 4:25 AM, Simon Riggs wrote: > At present log_newpage() produces log records called XLOG_HEAP_NEWPAGE. > > That routine is used by HEAP, BTREE, GIN, SPGIST rmgrs, as well as > various forks. > > WAL contains no information as to which rmgr the data refers to, > making debugging

[HACKERS] Refactoring log_newpage

2012-02-01 Thread Simon Riggs
At present log_newpage() produces log records called XLOG_HEAP_NEWPAGE. That routine is used by HEAP, BTREE, GIN, SPGIST rmgrs, as well as various forks. WAL contains no information as to which rmgr the data refers to, making debugging much harder and skewing efforts to optimise WAL traffic and i