Hi,
On 06/28/2015 08:10 AM, Fabien COELHO wrote:
Hello Tatsuo,
Main pgbench logic consists of single file pgbench.c which is 4036
lines of code as of today. This is not a small number and I think
it would be nice if it is divided into smaller files because it
will make it easier to maintain,
Hello Tatsuo,
Main pgbench logic consists of single file pgbench.c which is 4036 lines
of code as of today. This is not a small number and I think it would be
nice if it is divided into smaller files because it will make it easier
to maintain, add or change features of pgbench.
I do not
I do not think that this large file is a so big a problem (good
editors help navigation in the code), and I'm not sure that splitting
it would achieve much: there are not that many functions, some of
them are maybe long (main, threadRun, doCustom) but mostly for good
reasons.
My thoughts,
On 06/28/15 18:56, Tatsuo Ishii wrote:
I do not think that this large file is a so big a problem (good
editors help navigation in the code), and I'm not sure that splitting
it would achieve much: there are not that many functions, some of
them are maybe long (main, threadRun, doCustom) but
This is kind of surprising to me that two people are against
refactoring proposal (I understand that Fabien has pending patches for
pgbench and that could be a motivation for this though).
I think that's a misunderstanding. I'm not against refactoring - not at all,
and neither is Fabien I
On Sat, Jun 27, 2015 at 5:10 PM, Tatsuo Ishii is...@postgresql.org wrote:
Main pgbench logic consists of single file pgbench.c which is 4036
lines of code as of today. This is not a small number and I think it
would be nice if it is divided into smaller files because it will make
it easier to
Main pgbench logic consists of single file pgbench.c which is 4036
lines of code as of today. This is not a small number and I think it
would be nice if it is divided into smaller files because it will make
it easier to maintain, add or change features of pgbench. I will come
up with an idea how
