Re: [HACKERS] Remaining 'needs review' patchs in July commitfest

2015-07-30 Thread Robert Haas
On Wed, Jul 29, 2015 at 5:08 PM, Tom Lane t...@sss.pgh.pa.us wrote: Robert Haas robertmh...@gmail.com writes: On Tue, Jul 28, 2015 at 3:51 PM, Heikki Linnakangas hlinn...@iki.fi wrote: plpgsql raise statement with context Impasse. Everyone wants this feature in some form, but no consensus on

Re: [HACKERS] Remaining 'needs review' patchs in July commitfest

2015-07-29 Thread Tom Lane
Robert Haas robertmh...@gmail.com writes: On Tue, Jul 28, 2015 at 3:51 PM, Heikki Linnakangas hlinn...@iki.fi wrote: plpgsql raise statement with context Impasse. Everyone wants this feature in some form, but no consensus on whether to do this client-side or server-side. +1 for server-side.

Re: [HACKERS] Remaining 'needs review' patchs in July commitfest

2015-07-29 Thread Robert Haas
On Tue, Jul 28, 2015 at 3:51 PM, Heikki Linnakangas hlinn...@iki.fi wrote: plpgsql raise statement with context Impasse. Everyone wants this feature in some form, but no consensus on whether to do this client-side or server-side. +1 for server-side. Does anyone other than you even think that

Re: [HACKERS] Remaining 'needs review' patchs in July commitfest

2015-07-29 Thread Fabien COELHO
Hello Heikki, About two patches I submitted: pgbench - allow backslash-continuations in custom scripts Everyone wants the feature, using multi-line SELECTs in pgbench scripts, but we don't seem to be reaching a consensus on how it should work. I think we'll need to integrate the lexer,

Re: [HACKERS] Remaining 'needs review' patchs in July commitfest

2015-07-29 Thread Pavel Golub
Hello, Heikki. You wrote: HL 21 patches remain in Needs Review state, in the July commitfest. Some of HL them have a reviewer signed up. I have highlighted some of them below HL that worry me the most. What are we going to do about these? For each of HL them, I'd like the authors to have some

Re: [HACKERS] Remaining 'needs review' patchs in July commitfest

2015-07-28 Thread Tom Lane
Michael Paquier michael.paqu...@gmail.com writes: On Wed, Jul 29, 2015 at 5:22 AM, Heikki Linnakangas wrote: On 07/28/2015 11:01 PM, Alvaro Herrera wrote: Do we want to have this in src/test/modules or src/bin/pg_dump/t? Are we testing pg_dump here, or are we testing extensions? If the

Re: [HACKERS] Remaining 'needs review' patchs in July commitfest

2015-07-28 Thread Michael Paquier
On Wed, Jul 29, 2015 at 5:22 AM, Heikki Linnakangas wrote: On 07/28/2015 11:01 PM, Alvaro Herrera wrote: Improving test coverage of extensions with pg_dump Do we want to have this in src/test/modules or src/bin/pg_dump/t? Are we testing pg_dump here, or are we testing extensions? If the

Re: [HACKERS] Remaining 'needs review' patchs in July commitfest

2015-07-28 Thread Pavel Stehule
2015-07-28 21:51 GMT+02:00 Heikki Linnakangas hlinn...@iki.fi: 21 patches remain in Needs Review state, in the July commitfest. Some of them have a reviewer signed up. I have highlighted some of them below that worry me the most. What are we going to do about these? For each of them, I'd like

[HACKERS] Remaining 'needs review' patchs in July commitfest

2015-07-28 Thread Heikki Linnakangas
21 patches remain in Needs Review state, in the July commitfest. Some of them have a reviewer signed up. I have highlighted some of them below that worry me the most. What are we going to do about these? For each of them, I'd like the authors to have some idea on what they need to do to get

Re: [HACKERS] Remaining 'needs review' patchs in July commitfest

2015-07-28 Thread Josh Berkus
On 07/28/2015 12:51 PM, Heikki Linnakangas wrote: Everyone wants the feature, using multi-line SELECTs in pgbench scripts, but we don't seem to be reaching a consensus on how it should work. I think we'll need to integrate the lexer, but it would be nice to still support multi-statements as

Re: [HACKERS] Remaining 'needs review' patchs in July commitfest

2015-07-28 Thread Andres Freund
On 2015-07-28 22:51:55 +0300, Heikki Linnakangas wrote: checkpoint continuous flushing This does a big memory allocation at checkpoint, which Tom vehemently objects to. Uh. Didn't he just object to failing in that case? IIRC he even indicated tentative assent, a year or so back, with my idea

Re: [HACKERS] Remaining 'needs review' patchs in July commitfest

2015-07-28 Thread Alvaro Herrera
Heikki Linnakangas wrote: 21 patches remain in Needs Review state, in the July commitfest. Some of them have a reviewer signed up. I have highlighted some of them below that worry me the most. What are we going to do about these? For each of them, I'd like the authors to have some idea on what

Re: [HACKERS] Remaining 'needs review' patchs in July commitfest

2015-07-28 Thread Simon Riggs
On 28 July 2015 at 20:51, Heikki Linnakangas hlinn...@iki.fi wrote: multivariate statistics This has been a long discussion. Are we getting close to a committable state? This is important, but big. COPY RAW No consensus on whether to add this to the server's COPY command, or as a

Re: [HACKERS] Remaining 'needs review' patchs in July commitfest

2015-07-28 Thread Heikki Linnakangas
On 07/28/2015 11:30 PM, Simon Riggs wrote: I've added my name as committer to a few things, but won't be able to work on them until at least next week when I've finished 9.5 stuff. Happy to step back if anyone else wants to claim those. Thanks, every little helps! - Heikki -- Sent via

Re: [HACKERS] Remaining 'needs review' patchs in July commitfest

2015-07-28 Thread Tom Lane
Andres Freund and...@anarazel.de writes: On 2015-07-28 22:51:55 +0300, Heikki Linnakangas wrote: checkpoint continuous flushing This does a big memory allocation at checkpoint, which Tom vehemently objects to. Uh. Didn't he just object to failing in that case? Right. If it can fall back

Re: [HACKERS] Remaining 'needs review' patchs in July commitfest

2015-07-28 Thread Joe Conway
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 07/28/2015 01:22 PM, Heikki Linnakangas wrote: dblink: add polymorphic result functions Seems pretty ugly to me to add a dummy argument to functions, just so that you can specify the result type. The problem it's trying to solve is real,

Re: [HACKERS] Remaining 'needs review' patchs in July commitfest

2015-07-28 Thread Heikki Linnakangas
On 07/28/2015 11:01 PM, Alvaro Herrera wrote: Heikki Linnakangas wrote: pgbench - allow backslash-continuations in custom scripts Everyone wants the feature, using multi-line SELECTs in pgbench scripts, but we don't seem to be reaching a consensus on how it should work. I think we'll need to

Re: [HACKERS] Remaining 'needs review' patchs in July commitfest

2015-07-28 Thread Tomas Vondra
Hi, On 07/28/2015 09:51 PM, Heikki Linnakangas wrote: multivariate statistics This has been a long discussion. Are we getting close to a committable state? Certainly not - the discussion may seem long, but it only deals with some aspects of the patch so far. There was very little