On Mon, Jul 1, 2013 at 3:15 PM, Albe Laurenz wrote:
> Magnus Hagander wrote:
On Mon, Jun 17, 2013 at 1:49 PM, Albe Laurenz
wrote:
> I think that the column name is ok as it is, even if it
> is a bit long - I cannot come up with a more succinct
> idea. Perhaps "n_changed_si
Magnus Hagander wrote:
>>> On Mon, Jun 17, 2013 at 1:49 PM, Albe Laurenz
>>> wrote:
I think that the column name is ok as it is, even if it
is a bit long - I cannot come up with a more succinct
idea. Perhaps "n_changed_since_analyze" could be shortened
to "n_mod_since_analyze
On Mon, Jul 1, 2013 at 2:48 PM, Albe Laurenz wrote:
> Magnus Hagander wrote:
>> On Mon, Jun 17, 2013 at 1:49 PM, Albe Laurenz
>> wrote:
>>> This is a review of the patch in 5192d7d2.8020...@catalyst.net.nz
>>>
>>> The patch applies cleanly (with the exception of catversion.h of course),
>>> comp
Magnus Hagander wrote:
> On Mon, Jun 17, 2013 at 1:49 PM, Albe Laurenz wrote:
>> This is a review of the patch in 5192d7d2.8020...@catalyst.net.nz
>>
>> The patch applies cleanly (with the exception of catversion.h of course),
>> compiles without warnings and passes the regression tests.
>>
>> It
On Mon, Jun 17, 2013 at 1:49 PM, Albe Laurenz wrote:
> This is a review of the patch in 5192d7d2.8020...@catalyst.net.nz
>
> The patch applies cleanly (with the exception of catversion.h of course),
> compiles without warnings and passes the regression tests.
>
> It contains enough documentation,
This is a review of the patch in 5192d7d2.8020...@catalyst.net.nz
The patch applies cleanly (with the exception of catversion.h of course),
compiles without warnings and passes the regression tests.
It contains enough documentation, though I'd prefer
"Estimated number of rows modified since the t
