Kevin Grittner kevin.gritt...@wicourts.gov writes:
Leonardo F wrote:
New version of the patch, let me know if I can fix/change something
else.
All issues addressed, with one tiny nit-pick -- the get_bit and
set_bit methods are not part of the SQL standard. I took the liberty
of removing
New version of the patch, let me know if I can fix/change something else.
Leonardo
getsetbit.patch
Description: Binary data
--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers
Leonardo F wrote:
New version of the patch, let me know if I can fix/change something
else.
All issues addressed, with one tiny nit-pick -- the get_bit and
set_bit methods are not part of the SQL standard. I took the liberty
of removing SQL-standard from the documentation of these functions
so
All issues addressed, with one tiny nit-pick -- the get_bit and
set_bit methods are not part of the SQL standard.
Damn! I completely forgot to mention that I had no idea if what I wrote
in the docs made any sense...
Well thank you for your thorough review.
--
Sent via pgsql-hackers
In the
documentation, the get_bit and set_bit methods are added to a list
where we state The following SQL-standard functions work on bit
strings as well as character strings; however they are not
SQL-standard functions and are implemented on binary strings, not
character strings.
Ok, I
Leonardo F wrote:
In the documentation, the get_bit and set_bit methods are added
to a list where we state The following SQL-standard functions
work on bit strings as well as character strings; however they
are not SQL-standard functions and are implemented on binary
strings, not character
This patch no longer applies. Could you rebase it?
Done (I think). Added a couple of simple tests for bit overlay.
I didn't include the catversion.h changes: obviously the CATALOG_VERSION_NO has
to be changed.
Leonardo
Index: src/backend/utils/adt/varbit.c
Leonardo F wrote:
Done (I think). Added a couple of simple tests for bit overlay.
I didn't include the catversion.h changes: obviously the
CATALOG_VERSION_NO has to be changed.
[Following the Reviewing A Patch wiki, more or less]
The patch is in context diff format and applies cleanly.
Leonardo F 01/07/10 6:03 AM wrote:
attached a patch
Leonardo,
This patch no longer applies. Could you rebase it?
Thanks,
-Kevin
--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
