Re: [HACKERS] Review: psql include file using relative path

2011-07-06 Thread Robert Haas
On Mon, Jun 6, 2011 at 10:11 PM, Gurjeet Singh singh.gurj...@gmail.com wrote: On Mon, Jun 6, 2011 at 9:48 PM, Josh Kupershmidt schmi...@gmail.com wrote: On Sun, Jun 5, 2011 at 8:16 PM, Gurjeet Singh singh.gurj...@gmail.com wrote: Attached an updated patch. If you find it ready for

Re: [HACKERS] Review: psql include file using relative path

2011-07-06 Thread Gurjeet Singh
On Wed, Jul 6, 2011 at 11:58 AM, Robert Haas robertmh...@gmail.com wrote: On Mon, Jun 6, 2011 at 10:11 PM, Gurjeet Singh singh.gurj...@gmail.com wrote: On Mon, Jun 6, 2011 at 9:48 PM, Josh Kupershmidt schmi...@gmail.com wrote: On Sun, Jun 5, 2011 at 8:16 PM, Gurjeet Singh

Re: [HACKERS] Review: psql include file using relative path

2011-06-06 Thread Josh Kupershmidt
On Sun, Jun 5, 2011 at 8:16 PM, Gurjeet Singh singh.gurj...@gmail.com wrote: Attached an updated patch. If you find it ready for committer, please mark it so in the commitfest app. I can't find anything further to nitpick with this patch, and have marked it Ready For Committer in the CF.

Re: [HACKERS] Review: psql include file using relative path

2011-06-06 Thread Gurjeet Singh
On Mon, Jun 6, 2011 at 9:48 PM, Josh Kupershmidt schmi...@gmail.com wrote: On Sun, Jun 5, 2011 at 8:16 PM, Gurjeet Singh singh.gurj...@gmail.com wrote: Attached an updated patch. If you find it ready for committer, please mark it so in the commitfest app. I can't find anything further

Re: [HACKERS] Review: psql include file using relative path

2011-06-05 Thread Gurjeet Singh
On Sat, May 21, 2011 at 11:59 AM, Josh Kupershmidt schmi...@gmail.comwrote: On Fri, May 20, 2011 at 2:35 PM, Gurjeet Singh singh.gurj...@gmail.com wrote: On Sat, May 14, 2011 at 5:03 PM, Josh Kupershmidt schmi...@gmail.com wrote: Thanks a lot for the review. My responses are inline below.

Re: [HACKERS] Review: psql include file using relative path

2011-06-05 Thread Josh Kupershmidt
On Sun, Jun 5, 2011 at 10:21 AM, Gurjeet Singh singh.gurj...@gmail.com wrote: On Sat, May 21, 2011 at 11:59 AM, Josh Kupershmidt schmi...@gmail.com wrote: Tweaks applied, but omitted the C variable names as I don't think that adds much value. Your rewordings are fine, but the the article the

Re: [HACKERS] Review: psql include file using relative path

2011-06-05 Thread Gurjeet Singh
On Sun, Jun 5, 2011 at 1:06 PM, Josh Kupershmidt schmi...@gmail.com wrote: On Sun, Jun 5, 2011 at 10:21 AM, Gurjeet Singh singh.gurj...@gmail.com wrote: On Sat, May 21, 2011 at 11:59 AM, Josh Kupershmidt schmi...@gmail.com wrote: Tweaks applied, but omitted the C variable names as I

Re: [HACKERS] Review: psql include file using relative path

2011-05-21 Thread Josh Kupershmidt
On Fri, May 20, 2011 at 2:35 PM, Gurjeet Singh singh.gurj...@gmail.com wrote: On Sat, May 14, 2011 at 5:03 PM, Josh Kupershmidt schmi...@gmail.com wrote: Thanks a lot for the review. My responses are inline below. Thanks for the fixes. Your updated patch is sent as a patch-upon-a-patch, it'll

Re: [HACKERS] Review: psql include file using relative path

2011-05-20 Thread Gurjeet Singh
Thanks a lot for the review. My responses are inline below. On Sat, May 14, 2011 at 5:03 PM, Josh Kupershmidt schmi...@gmail.comwrote: I had a chance to give this patch a look. This review is of the second patch posted by Gurjeet, at:

Re: [HACKERS] Review: psql include file using relative path

2011-05-20 Thread Gurjeet Singh
On Tue, May 17, 2011 at 2:43 PM, Robert Haas robertmh...@gmail.com wrote: On Sat, May 14, 2011 at 5:03 PM, Josh Kupershmidt schmi...@gmail.com wrote: I had a chance to give this patch a look. This review is of the second patch posted by Gurjeet, at:

Re: [HACKERS] Review: psql include file using relative path

2011-05-17 Thread Robert Haas
On Sat, May 14, 2011 at 5:03 PM, Josh Kupershmidt schmi...@gmail.com wrote: I had a chance to give this patch a look. This review is of the second patch posted by Gurjeet, at: http://archives.postgresql.org/message-id/AANLkTi=yjb_a+ggt_pxmrqhbhyid6aswwb8h-lw-k...@mail.gmail.com Cool. I see

[HACKERS] Review: psql include file using relative path

2011-05-14 Thread Josh Kupershmidt
I had a chance to give this patch a look. This review is of the second patch posted by Gurjeet, at: http://archives.postgresql.org/message-id/AANLkTi=yjb_a+ggt_pxmrqhbhyid6aswwb8h-lw-k...@mail.gmail.com == Summary == This patch implements the \ir command for psql, with a long alias