On Wed, Jul 6, 2011 at 11:58 AM, Robert Haas wrote:
> On Mon, Jun 6, 2011 at 10:11 PM, Gurjeet Singh
> wrote:
> > On Mon, Jun 6, 2011 at 9:48 PM, Josh Kupershmidt
> wrote:
> >>
> >> On Sun, Jun 5, 2011 at 8:16 PM, Gurjeet Singh
> >> wrote:
> >> > Attached an updated patch.
> >> >
> >> > If you
On Mon, Jun 6, 2011 at 10:11 PM, Gurjeet Singh wrote:
> On Mon, Jun 6, 2011 at 9:48 PM, Josh Kupershmidt wrote:
>>
>> On Sun, Jun 5, 2011 at 8:16 PM, Gurjeet Singh
>> wrote:
>> > Attached an updated patch.
>> >
>> > If you find it ready for committer, please mark it so in the commitfest
>> > app
On Mon, Jun 6, 2011 at 9:48 PM, Josh Kupershmidt wrote:
> On Sun, Jun 5, 2011 at 8:16 PM, Gurjeet Singh
> wrote:
> > Attached an updated patch.
> >
> > If you find it ready for committer, please mark it so in the commitfest
> app.
>
> I can't find anything further to nitpick with this patch, and
On Sun, Jun 5, 2011 at 8:16 PM, Gurjeet Singh wrote:
> Attached an updated patch.
>
> If you find it ready for committer, please mark it so in the commitfest app.
I can't find anything further to nitpick with this patch, and have
marked it Ready For Committer in the CF. Thanks for your work on th
On Sun, Jun 5, 2011 at 1:06 PM, Josh Kupershmidt wrote:
> On Sun, Jun 5, 2011 at 10:21 AM, Gurjeet Singh
> wrote:
> > On Sat, May 21, 2011 at 11:59 AM, Josh Kupershmidt
> > wrote:
>
> > Tweaks applied, but omitted the C variable names as I don't think that
> adds
> > much value.
>
> Your reword
On Sun, Jun 5, 2011 at 10:21 AM, Gurjeet Singh wrote:
> On Sat, May 21, 2011 at 11:59 AM, Josh Kupershmidt
> wrote:
> Tweaks applied, but omitted the C variable names as I don't think that adds
> much value.
Your rewordings are fine, but the the article "the" is missing in a
few spots, e.g.
*
On Sat, May 21, 2011 at 11:59 AM, Josh Kupershmidt wrote:
> On Fri, May 20, 2011 at 2:35 PM, Gurjeet Singh
> wrote:
> > On Sat, May 14, 2011 at 5:03 PM, Josh Kupershmidt
> > wrote:
> > Thanks a lot for the review. My responses are inline below.
>
> Thanks for the fixes. Your updated patch is sen
On Fri, May 20, 2011 at 2:35 PM, Gurjeet Singh wrote:
> On Sat, May 14, 2011 at 5:03 PM, Josh Kupershmidt
> wrote:
> Thanks a lot for the review. My responses are inline below.
Thanks for the fixes. Your updated patch is sent as a
patch-upon-a-patch, it'll probably be easier for everyone
(partic
On Tue, May 17, 2011 at 2:43 PM, Robert Haas wrote:
> On Sat, May 14, 2011 at 5:03 PM, Josh Kupershmidt
> wrote:
> > I had a chance to give this patch a look. This review is of the second
> > patch posted by Gurjeet, at:
> >
> http://archives.postgresql.org/message-id/AANLkTi=yjb_a+ggt_pxmrqhbhy
Thanks a lot for the review. My responses are inline below.
On Sat, May 14, 2011 at 5:03 PM, Josh Kupershmidt wrote:
> I had a chance to give this patch a look. This review is of the second
> patch posted by Gurjeet, at:
>
> http://archives.postgresql.org/message-id/AANLkTi=yjb_a+ggt_pxmrqhbhyid6
On Sat, May 14, 2011 at 5:03 PM, Josh Kupershmidt wrote:
> I had a chance to give this patch a look. This review is of the second
> patch posted by Gurjeet, at:
> http://archives.postgresql.org/message-id/AANLkTi=yjb_a+ggt_pxmrqhbhyid6aswwb8h-lw-k...@mail.gmail.com
Cool. I see you (or someone) h
I had a chance to give this patch a look. This review is of the second
patch posted by Gurjeet, at:
http://archives.postgresql.org/message-id/AANLkTi=yjb_a+ggt_pxmrqhbhyid6aswwb8h-lw-k...@mail.gmail.com
== Summary ==
This patch implements the \ir command for psql, with a long alias
\include_relati
12 matches
Mail list logo
