No problem, I have time for clearing. But are these functions
guaranteed to be included in the contrib? If there is no guarantee,
seems the time of clearing will be wasted. (5 years ago I have already
cleaned one open-source library on demand and after that it was not
approved for PEAR repository,
Hi,
sorry for not having completed this review, yet. As you are obviously
looking at the patch as well, I'll try to quickly write down my points
so far.
Trying to compile the intarray module, I now receive an error:
error: ‘INT4OID’ undeclared (first use in this function)
That can be solved
Markus Wanner wrote:
Dmitry Koterov wrote:
But, what about intarray patch? Does somebody plan to review it? I'd
prefer to include it too. If you approve, I'll correct the code style
in intarray contrib patch too.
I've already volunteered for reviewing it as well. I just felt like
splitting t
Hi,
Dmitry Koterov wrote:
I'll correct everything and send a patch in a couple of days.
Cool, thank you.
Are you
completely sure that this patch will be included?
Uh.. I'm not a committer, but I'm pretty sure your patch has good chances.
I can help with SGML documentation, if you want.
B
OK, thank you for your review.
I'll correct everything and send a patch in a couple of days. Are you
completely sure that this patch will be included? If not, seems the work of
the patch standartization has much lower priority, and I will not hurry so
much.
But, what about intarray patch? Does so
Markus Wanner <[EMAIL PROTECTED]> writes:
> Submission review: we generally prefer having patches archived on our
> mailing lists, so please just send future patches or revisions of this
> patch to our lists (I prefer -hackers, but probably -patches is still
> the official one).
Please. But -patc
Hi,
this is my first "official" review. I've tried to follow the "Review a
patch" guidelines from the wiki - thanks Simon, that was pretty helpful.
This review covers only the intagg additions.
Dmitry Koterov wrote:
Here are these functions with detailed documentation:
http://en.dklab.ru/lib/d
