Re: [HACKERS] SSI using rw-conflict lists

2010-11-29 Thread Heikki Linnakangas
On 28.11.2010 23:44, Kevin Grittner wrote: (1) Should these be moved to ShmemVariableCache, or is it OK to leave them in this structure as long as I comment it adequately? If they're only used by predicate.c, it seems better to leave them where they are. (2) Would it be a good idea to

Re: [HACKERS] SSI using rw-conflict lists

2010-11-29 Thread Kevin Grittner
Heikki Linnakangas heikki.linnakan...@enterprisedb.com wrote: Maybe invent a short name for PredLockTranList and/or the fields? Done: http://git.postgresql.org/gitweb?p=users/kgrittn/postgres.git;a=commitdiff;h=44c8f221100b87fc7c23425f53f2fd38d735b7d2 I'd suggest a union field. Done:

[HACKERS] SSI using rw-conflict lists

2010-11-28 Thread Kevin Grittner
Well, it's been a productive holiday weekend. I've completed the switch of the SSI implementation from one conflict pointer in and one conflict pointer out per transaction to a list of conflicts between transactions. This eliminated all false positives in my dtester suite. The only test which