Re: [HACKERS] SlruPhysicalReadPage

2008-10-15 Thread Simon Riggs
On Wed, 2008-10-15 at 15:13 -0400, Tom Lane wrote: > Simon Riggs <[EMAIL PROTECTED]> writes: > > This seems inconsistent. Why is the first page OK to be created, but any > > other pages after that cause failure? ISTM the first page is nothing > > special. > > It's special on the writing side, I'm

Re: [HACKERS] SlruPhysicalReadPage

2008-10-15 Thread Tom Lane
Simon Riggs <[EMAIL PROTECTED]> writes: > This seems inconsistent. Why is the first page OK to be created, but any > other pages after that cause failure? ISTM the first page is nothing > special. It's special on the writing side, I'm not sure why the reading side wouldn't treat it specially too.

[HACKERS] SlruPhysicalReadPage

2008-10-15 Thread Simon Riggs
SlruPhysicalReadPage() succeeds InRecovery if the file does not exist. BUT, if the file exists but is wrong size then it will still fail even InRecovery. This seems inconsistent. Why is the first page OK to be created, but any other pages after that cause failure? ISTM the first page is nothing