Re: [HACKERS] Small patch: fix double variable initializations in policy.c

2016-03-20 Thread Tom Lane
Aleksander Alekseev writes: > I'm quite sure that there is no need to initialize these variables > twice. First patch fixes this. Also I discovered that policy.c is not > properly pgindent'ed. Second patch fixes this too. Applied the first patch --- though I chose to do it the other way (keep the

[HACKERS] Small patch: fix double variable initializations in policy.c

2016-03-16 Thread Aleksander Alekseev
Hello I discovered a pretty weird code. policy.c:1083 ``` char *qual_value; ParseState *qual_pstate = make_parsestate(NULL); /* parsestate is built just to build the range table */ qual_pstate = make_parsestate(NULL); ``` policy.c:1125 ``` char *with_check_value; ParseState *with_