Re: [HACKERS] Some bugs in psql_complete of psql

2016-01-26 Thread Kyotaro HORIGUCHI
Hello, thank you for committing this. At Sat, 16 Jan 2016 21:09:26 -0500, Peter Eisentraut wrote in <569af7d6.9090...@gmx.net> > On 1/12/16 9:46 PM, Peter Eisentraut wrote: > > On 12/22/15 4:44 AM, Kyotaro HORIGUCHI wrote: > >> 1. 0001-Fix-tab-complete-of-CREATE-INDEX.patch >

Re: [HACKERS] Some bugs in psql_complete of psql

2016-01-16 Thread Peter Eisentraut
On 1/12/16 9:46 PM, Peter Eisentraut wrote: > On 12/22/15 4:44 AM, Kyotaro HORIGUCHI wrote: >> 1. 0001-Fix-tab-complete-of-CREATE-INDEX.patch >> >> Fixes completion for CREATE INDEX in ordinary way. > > This part has been fixed in another thread. Please check whether that > satisfies all your

Re: [HACKERS] Some bugs in psql_complete of psql

2016-01-12 Thread Peter Eisentraut
On 12/22/15 4:44 AM, Kyotaro HORIGUCHI wrote: > 1. 0001-Fix-tab-complete-of-CREATE-INDEX.patch > > Fixes completion for CREATE INDEX in ordinary way. This part has been fixed in another thread. Please check whether that satisfies all your issues. > 3.

Re: [HACKERS] Some bugs in psql_complete of psql

2015-12-22 Thread Kyotaro HORIGUCHI
Hello, I returned to this since Thomas' psql-completion patch has been committed. This patch has been recreated on it. "IN TABLESPACE xxx OWNED BY" has been alredy fixed so I removed it. The attched files are the following, 1. 0001-Fix-tab-complete-of-CREATE-INDEX.patch Fixes completion for

Re: [HACKERS] Some bugs in psql_complete of psql

2015-12-08 Thread Kyotaro HORIGUCHI
Hello, thank you for reviewing. # I injured at fingertip, It's quite nuisance and make me more # slower to type in.. I posted another patch to totally refactor psql-complete so I don't put revised patch of this for now but this discussion has an importance for me so please continue to discuss on

Re: [HACKERS] Some bugs in psql_complete of psql

2015-12-04 Thread Fujii Masao
On Fri, Nov 6, 2015 at 11:27 AM, Kyotaro HORIGUCHI wrote: > Hello, thank you for the comments. > > The revised version of this patch is attached. Thanks for updating the patch! I tested whether the following patterns work as expected or not. CREATE UNIQUE INDEX

Re: [HACKERS] Some bugs in psql_complete of psql

2015-11-05 Thread Kyotaro HORIGUCHI
Hello, thank you for the comments. The revised version of this patch is attached. - Prevent complete with ON to the sequence "[CREATE] [UNIQUE] INDEX ON". - Added TABLESPACE to the preposition list for SECURITY LABEL. I think that the current completion mechanism is simple, fast and maybe

Re: [HACKERS] Some bugs in psql_complete of psql

2015-11-05 Thread Fujii Masao
On Wed, Nov 4, 2015 at 5:27 PM, Kyotaro HORIGUCHI wrote: > Hello, I found that a typo(?) in tab-complete.c. > >> /* ALTER TABLE,INDEX,MATERIALIZED VIEW xxx ALL IN TABLESPACE xxx OWNED BY */ >> else if (pg_strcasecmp(prev6_wd, "ALL") == 0 && >>

[HACKERS] Some bugs in psql_complete of psql

2015-11-04 Thread Kyotaro HORIGUCHI
Hello, I found that a typo(?) in tab-complete.c. > /* ALTER TABLE,INDEX,MATERIALIZED VIEW xxx ALL IN TABLESPACE xxx OWNED BY */ > else if (pg_strcasecmp(prev6_wd, "ALL") == 0 && >pg_strcasecmp(prev5_wd, "IN") == 0 && >pg_strcasecmp(prev4_wd, "TABLESPACE") == 0 && >