Re: [HACKERS] Still a few flaws in configure's default CFLAGS selection

2003-10-27 Thread Jan Wieck
Bruce Momjian wrote: Jan Wieck wrote: > In fact, even though I was debugging the backend regularly, I removed -g > and added it only when I wanted to debug. > It did somethimes in the past proove to be good luck to have symbols in a core file accidentially. If you want to find them in an arbitra

Re: [HACKERS] Still a few flaws in configure's default CFLAGS selection

2003-10-27 Thread Bruce Momjian
Jan Wieck wrote: > > In fact, even though I was debugging the backend regularly, I removed -g > > and added it only when I wanted to debug. > > > > It did somethimes in the past proove to be good luck to have symbols in > a core file accidentially. If you want to find them in an arbitrary out >

Re: [HACKERS] Still a few flaws in configure's default CFLAGS selection

2003-10-27 Thread Jan Wieck
Bruce Momjian wrote: pgman wrote: Jan Wieck wrote: > >> >> > What Peter was advocating in that thread was that we enable -g by > >> >> > default *when building with gcc*. I have no problem with that, since > >> >> > there is (allegedly) no performance penalty for -g with gcc. However, > >> >> >

Re: [HACKERS] Still a few flaws in configure's default CFLAGS selection

2003-10-27 Thread Bruce Momjian
pgman wrote: > Jan Wieck wrote: > > >> >> > What Peter was advocating in that thread was that we enable -g by > > >> >> > default *when building with gcc*. I have no problem with that, since > > >> >> > there is (allegedly) no performance penalty for -g with gcc. However, > > >> >> > the actual p

Re: [HACKERS] Still a few flaws in configure's default CFLAGS selection

2003-10-27 Thread Bruce Momjian
Jan Wieck wrote: > >> >> > What Peter was advocating in that thread was that we enable -g by > >> >> > default *when building with gcc*. I have no problem with that, since > >> >> > there is (allegedly) no performance penalty for -g with gcc. However, > >> >> > the actual present behavior of our

Re: [HACKERS] Still a few flaws in configure's default CFLAGS selection

2003-10-27 Thread Jan Wieck
Bruce Momjian wrote: Jan Wieck wrote: Bruce Momjian wrote: > Peter Eisentraut wrote: >> Tom Lane writes: >> >> > What Peter was advocating in that thread was that we enable -g by >> > default *when building with gcc*. I have no problem with that, since >> > there is (allegedly) no performance pen

Re: [HACKERS] Still a few flaws in configure's default CFLAGS selection

2003-10-27 Thread Kevin Brown
Bruce Momjian wrote: > Well, we don't want to use debug for non-gcc (no optimization) so do we > do -g for gcc, and then --enable-debug does nothing. Seems people can > decide for themselves. But doesn't --enable-debug turn off optimization? It's really a question of what the default behavior s

Re: [HACKERS] Still a few flaws in configure's default CFLAGS selection

2003-10-26 Thread Bruce Momjian
Kevin Brown wrote: > > > You do realize that as of now, -g is the default for gcc? > > It is? > > [EMAIL PROTECTED]:~/tmp$ gcc -c foo.c > [EMAIL PROTECTED]:~/tmp$ ls -l foo.o > -rw-r--r--1 kevinkevin 876 Oct 26 18:52 foo.o > [EMAIL PROTECTED]:~/tmp$ gcc -g -c foo.c > [EMAIL PROTEC

Re: [HACKERS] Still a few flaws in configure's default CFLAGS selection

2003-10-26 Thread Bruce Momjian
Jan Wieck wrote: > Bruce Momjian wrote: > > Peter Eisentraut wrote: > >> Tom Lane writes: > >> > >> > What Peter was advocating in that thread was that we enable -g by > >> > default *when building with gcc*. I have no problem with that, since > >> > there is (allegedly) no performance penalty fo

Re: [HACKERS] Still a few flaws in configure's default CFLAGS selection

2003-10-26 Thread Kevin Brown
Bruce Momjian wrote: > Peter Eisentraut wrote: > > Tom Lane writes: > > > > > What Peter was advocating in that thread was that we enable -g by > > > default *when building with gcc*. I have no problem with that, since > > > there is (allegedly) no performance penalty for -g with gcc. However, >

Re: [HACKERS] Still a few flaws in configure's default CFLAGS selection

2003-10-26 Thread Jan Wieck
Bruce Momjian wrote: Peter Eisentraut wrote: Tom Lane writes: > What Peter was advocating in that thread was that we enable -g by > default *when building with gcc*. I have no problem with that, since > there is (allegedly) no performance penalty for -g with gcc. However, > the actual present be

Re: [HACKERS] Still a few flaws in configure's default CFLAGS selection

2003-10-24 Thread Bruce Momjian
Peter Eisentraut wrote: > Tom Lane writes: > > > What Peter was advocating in that thread was that we enable -g by > > default *when building with gcc*. I have no problem with that, since > > there is (allegedly) no performance penalty for -g with gcc. However, > > the actual present behavior of

Re: [HACKERS] Still a few flaws in configure's default CFLAGS selection

2003-10-16 Thread Tom Lane
Bruce Momjian <[EMAIL PROTECTED]> writes: >> Tom Lane wrote: >>> Bruce Momjian <[EMAIL PROTECTED]> writes: >>> Also, I thought Peter advocated adding -g a few releases back. >> I don't recall any such vote. > The vote was whether -g should be used for a default compile. > Here is the thread disc

Re: [HACKERS] Still a few flaws in configure's default CFLAGS selection

2003-10-16 Thread Bruce Momjian
Bruce Momjian wrote: > Tom Lane wrote: > > Bruce Momjian <[EMAIL PROTECTED]> writes: > > > Also, I thought Peter advocated adding -g a few releases back. I didn't > > > agree, but I lost the vote, so I thought it was done. Were we > > > supresssing -g in older releases? Peter? > > > > I don't r

Re: [HACKERS] Still a few flaws in configure's default CFLAGS selection

2003-10-16 Thread Bruce Momjian
Tom Lane wrote: > Bruce Momjian <[EMAIL PROTECTED]> writes: > > The vote was whether -g should be used for a default compile. Of course > > --enable-debug would continue using -g. Maybe we kept --enable-debug > > for backward compatibility or to force -g if you modified CFLAGS? > > I can't see w

Re: [HACKERS] Still a few flaws in configure's default CFLAGS selection

2003-10-16 Thread Tom Lane
Bruce Momjian <[EMAIL PROTECTED]> writes: > The vote was whether -g should be used for a default compile. Of course > --enable-debug would continue using -g. Maybe we kept --enable-debug > for backward compatibility or to force -g if you modified CFLAGS? I can't see why we would have kept --enab

Re: [HACKERS] Still a few flaws in configure's default CFLAGS selection

2003-10-16 Thread Bruce Momjian
Tom Lane wrote: > Bruce Momjian <[EMAIL PROTECTED]> writes: > > Also, I thought Peter advocated adding -g a few releases back. I didn't > > agree, but I lost the vote, so I thought it was done. Were we > > supresssing -g in older releases? Peter? > > I don't recall any such vote. Had we done t

Re: [HACKERS] Still a few flaws in configure's default CFLAGS selection

2003-10-16 Thread Tom Lane
Bruce Momjian <[EMAIL PROTECTED]> writes: > Also, I thought Peter advocated adding -g a few releases back. I didn't > agree, but I lost the vote, so I thought it was done. Were we > supresssing -g in older releases? Peter? I don't recall any such vote. Had we done that, we'd have removed --ena

Re: [HACKERS] Still a few flaws in configure's default CFLAGS selection

2003-10-16 Thread Bruce Momjian
Tom Lane wrote: > Greg Stark <[EMAIL PROTECTED]> writes: > > uh, since you asked. I think the logic is that, at least with gcc, -g > > is never harmful since you can compile with -O and -g and then strip > > later if necessary. > > Yeah, but ... > > > Does it still default to -g with compilers th

Re: [HACKERS] Still a few flaws in configure's default CFLAGS selection

2003-10-15 Thread Tom Lane
Greg Stark <[EMAIL PROTECTED]> writes: > uh, since you asked. I think the logic is that, at least with gcc, -g > is never harmful since you can compile with -O and -g and then strip > later if necessary. Yeah, but ... > Does it still default to -g with compilers that > cannot do -O and -g togethe

Re: [HACKERS] Still a few flaws in configure's default CFLAGS selection

2003-10-15 Thread Bruce Momjian
Tom Lane wrote: > While fooling with adding -fno-strict-aliasing to configure, I realized > that there are still some oddities about its selection of CFLAGS. The > problems stem from the fact that autoconf will always select a default > value of CFLAGS that includes "-g", if the compiler accepts "

[HACKERS] Still a few flaws in configure's default CFLAGS selection

2003-10-15 Thread Tom Lane
While fooling with adding -fno-strict-aliasing to configure, I realized that there are still some oddities about its selection of CFLAGS. The problems stem from the fact that autoconf will always select a default value of CFLAGS that includes "-g", if the compiler accepts "-g" at all. This has a c