On Tue, Dec 23, 2014 at 5:21 AM, Petr Jelinek wrote:
> Attached is v3 which besides the fixes mentioned above also includes changes
> discussed with Tomas (except the CREATE/DROP TABLESAMPLE METHOD), fixes for
> crash with FETCH FIRST and is rebased against current master.
This patch needs a rebas
On 22/12/14 20:14, Jaime Casanova wrote:
On Thu, Dec 18, 2014 at 7:14 AM, Petr Jelinek wrote:
Hi,
v2 version of this patch is attached.
a few more tests revealed that passing null as the sample size
argument works, and it shouldn't.
Fixed.
in repeatable it gives an error if i use null a
On Thu, Dec 18, 2014 at 7:14 AM, Petr Jelinek wrote:
> Hi,
>
> v2 version of this patch is attached.
>
a few more tests revealed that passing null as the sample size
argument works, and it shouldn't.
in repeatable it gives an error if i use null as argument but it gives
a syntax error, and it sho
On 22.12.2014 10:07, Petr Jelinek wrote:
> On 21/12/14 18:38, Tomas Vondra wrote:
>>
>> (1) The patch adds a new catalog, but does not bump CATVERSION.
>>
>
> I thought this was always done by committer?
Right. Sorry for the noise.
>
>> (2) The catalog naming (pg_tablesamplemethod) seems a bit
On 21/12/14 18:38, Tomas Vondra wrote:
Hi,
On 18.12.2014 13:14, Petr Jelinek wrote:
Hi,
v2 version of this patch is attached.
I did a review of this v2 patch today. I plan to do a bit more testing,
but these are my comments/questions so far:
Thanks for looking at it!
(0) There's a TABLE
On Mon, Dec 22, 2014 at 2:38 AM, Tomas Vondra wrote:
> (1) The patch adds a new catalog, but does not bump CATVERSION.
FWIW, this part is managed by the committer when this patch is picked up.
--
Michael
--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to y
Hi,
On 18.12.2014 13:14, Petr Jelinek wrote:
> Hi,
>
> v2 version of this patch is attached.
I did a review of this v2 patch today. I plan to do a bit more testing,
but these are my comments/questions so far:
(0) There's a TABLESAMPLE page at the wiki, not updated since 2012:
https://wiki.
Hi,
v2 version of this patch is attached.
On 16/12/14 09:31, Petr Jelinek wrote:
On 16/12/14 08:43, Jaime Casanova wrote:
Sadly when the jsonb functions patch was committed a few oids where
used, so you should update the ones you are using. at least to make
the patch easier for testing.
Wi
On 17/12/14 19:55, Alvaro Herrera wrote:
I noticed that this makes REPEATABLE a reserved keyword, which is
currently an unreserved one. Can we avoid that?
I added it because I did not find any other way to fix the shift/reduce
conflicts that bison complained about. I am no bison expert thoug
I noticed that this makes REPEATABLE a reserved keyword, which is
currently an unreserved one. Can we avoid that?
--
Álvaro Herrerahttp://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
--
Sent via pgsql-hackers mailing list (pgsql-ha
On 16/12/14 08:43, Jaime Casanova wrote:
On Wed, Dec 10, 2014 at 6:24 PM, Petr Jelinek wrote:
Hello,
Attached is a basic implementation of TABLESAMPLE clause. It's SQL standard
clause and couple of people tried to submit it before so I think I don't
need to explain in length what it does - bas
On Wed, Dec 10, 2014 at 6:24 PM, Petr Jelinek wrote:
> Hello,
>
> Attached is a basic implementation of TABLESAMPLE clause. It's SQL standard
> clause and couple of people tried to submit it before so I think I don't
> need to explain in length what it does - basically returns "random" sample
> of
On 11/12/14 00:24, Petr Jelinek wrote:
Hello,
Attached is a basic implementation of TABLESAMPLE clause. It's SQL
standard clause and couple of people tried to submit it before so I
think I don't need to explain in length what it does - basically returns
"random" sample of a table using a specifi
Hello,
Attached is a basic implementation of TABLESAMPLE clause. It's SQL
standard clause and couple of people tried to submit it before so I
think I don't need to explain in length what it does - basically returns
"random" sample of a table using a specified sampling method.
I implemented b
101 - 114 of 114 matches
Mail list logo
