Re: [HACKERS] Testing DDL deparsing support

2014-12-09 Thread Bruce Momjian
On Mon, Dec 8, 2014 at 12:43:36PM -0500, Robert Haas wrote: > On Sat, Dec 6, 2014 at 10:43 PM, Bruce Momjian wrote: > > This causes creation DDL is checked if it is used in the regression > > database, but what about ALTER and DROP? pg_dump doesn't issue those, > > except in special cases like i

Re: [HACKERS] Testing DDL deparsing support

2014-12-08 Thread Robert Haas
On Sat, Dec 6, 2014 at 10:43 PM, Bruce Momjian wrote: > This causes creation DDL is checked if it is used in the regression > database, but what about ALTER and DROP? pg_dump doesn't issue those, > except in special cases like inheritance. The proposed testing mechanism should cover any ALTER co

Re: [HACKERS] Testing DDL deparsing support

2014-12-07 Thread Ian Barwick
On 14/12/07 12:43, Bruce Momjian wrote: > On Tue, Dec 2, 2014 at 03:13:07PM -0300, Alvaro Herrera wrote: >> Robert Haas wrote: >>> On Thu, Nov 27, 2014 at 11:43 PM, Ian Barwick wrote: >> A simple schedule to demonstrate this is available; execute from the src/test/regress/ directory lik

Re: [HACKERS] Testing DDL deparsing support

2014-12-06 Thread Bruce Momjian
On Tue, Dec 2, 2014 at 03:13:07PM -0300, Alvaro Herrera wrote: > Robert Haas wrote: > > On Thu, Nov 27, 2014 at 11:43 PM, Ian Barwick wrote: > > > > A simple schedule to demonstrate this is available; execute from the > > > src/test/regress/ directory like this: > > > > > > ./pg_regress \ >

Re: [HACKERS] Testing DDL deparsing support

2014-12-05 Thread Bruce Momjian
On Fri, Dec 5, 2014 at 04:10:12PM -0300, Alvaro Herrera wrote: > Well, ALTER TABLE is special: you can give several subcommands, and each > subcommand can be one of a rather long list of possible subcommands. > Testing every combination would mean a combinatorial explosion, which > would indeed be

Re: [HACKERS] Testing DDL deparsing support

2014-12-05 Thread Alvaro Herrera
Bruce Momjian wrote: > On Fri, Dec 5, 2014 at 09:29:59AM -0300, Alvaro Herrera wrote: > > Bruce Momjian wrote: > > > On Fri, Nov 28, 2014 at 01:43:36PM +0900, Ian Barwick wrote: > > > > Standard regression tests are helpful because patch authors include new > > > > test > > > > cases in the patch

Re: [HACKERS] Testing DDL deparsing support

2014-12-05 Thread Bruce Momjian
On Fri, Dec 5, 2014 at 09:29:59AM -0300, Alvaro Herrera wrote: > Bruce Momjian wrote: > > On Fri, Nov 28, 2014 at 01:43:36PM +0900, Ian Barwick wrote: > > > Standard regression tests are helpful because patch authors include new > > > test > > > cases in the patches that stress their new options

Re: [HACKERS] Testing DDL deparsing support

2014-12-05 Thread Alvaro Herrera
Bruce Momjian wrote: > On Fri, Nov 28, 2014 at 01:43:36PM +0900, Ian Barwick wrote: > > Standard regression tests are helpful because patch authors include new test > > cases in the patches that stress their new options or commands. This new > > test > > framework needs to be something that inter

Re: [HACKERS] Testing DDL deparsing support

2014-12-05 Thread Bruce Momjian
On Fri, Nov 28, 2014 at 01:43:36PM +0900, Ian Barwick wrote: > Standard regression tests are helpful because patch authors include new test > cases in the patches that stress their new options or commands. This new test > framework needs to be something that internally runs the regression tests an

Re: [HACKERS] Testing DDL deparsing support

2014-12-02 Thread Alvaro Herrera
Robert Haas wrote: > On Thu, Nov 27, 2014 at 11:43 PM, Ian Barwick wrote: > > A simple schedule to demonstrate this is available; execute from the > > src/test/regress/ directory like this: > > > > ./pg_regress \ > > --temp-install=./tmp_check \ > > --top-builddir=../../.. \ > >

Re: [HACKERS] Testing DDL deparsing support

2014-12-02 Thread Robert Haas
On Thu, Nov 27, 2014 at 11:43 PM, Ian Barwick wrote: > DDL deparsing is a feature that allows collection of DDL commands as they > are > executed in a server, in some flexible, complete, and fully-contained format > that allows manipulation, storage, and transmission. This feature has > several >

[HACKERS] Testing DDL deparsing support

2014-11-27 Thread Ian Barwick
DDL deparsing is a feature that allows collection of DDL commands as they are executed in a server, in some flexible, complete, and fully-contained format that allows manipulation, storage, and transmission. This feature has several use cases; the two best known ones are DDL replication and DDL a