Re: [HACKERS] Too strict check when starting from a basebackup taken off a standby

2014-12-18 Thread Andres Freund
On 2014-12-16 18:37:48 +0200, Heikki Linnakangas wrote: On 12/11/2014 04:21 PM, Marco Nenciarini wrote: Il 11/12/14 12:38, Andres Freund ha scritto: On December 11, 2014 9:56:09 AM CET, Heikki Linnakangas hlinnakan...@vmware.com wrote: On 12/11/2014 05:45 AM, Andres Freund wrote: Yeah. I

Re: [HACKERS] Too strict check when starting from a basebackup taken off a standby

2014-12-11 Thread Heikki Linnakangas
On 12/11/2014 05:45 AM, Andres Freund wrote: A customer recently reported getting backup_label contains data inconsistent with control file after taking a basebackup from a standby and starting it with a typo in primary_conninfo. When starting postgres from a basebackup StartupXLOG() has the

Re: [HACKERS] Too strict check when starting from a basebackup taken off a standby

2014-12-11 Thread Andres Freund
On December 11, 2014 9:56:09 AM CET, Heikki Linnakangas hlinnakan...@vmware.com wrote: On 12/11/2014 05:45 AM, Andres Freund wrote: A customer recently reported getting backup_label contains data inconsistent with control file after taking a basebackup from a standby and starting it with a

Re: [HACKERS] Too strict check when starting from a basebackup taken off a standby

2014-12-11 Thread Marco Nenciarini
Il 11/12/14 12:38, Andres Freund ha scritto: On December 11, 2014 9:56:09 AM CET, Heikki Linnakangas hlinnakan...@vmware.com wrote: On 12/11/2014 05:45 AM, Andres Freund wrote: Yeah. I was not able to reproduce this, but I'm clearly missing something, since both you and Sergey have seen

[HACKERS] Too strict check when starting from a basebackup taken off a standby

2014-12-10 Thread Andres Freund
Hi, A customer recently reported getting backup_label contains data inconsistent with control file after taking a basebackup from a standby and starting it with a typo in primary_conninfo. When starting postgres from a basebackup StartupXLOG() has the follow code to deal with backup labels: