Re: [HACKERS] Uncopied parameters on CREATE TABLE LIKE

2008-08-13 Thread Bruce Momjian
Added to TODO: > o Add CREATE TABLE LIKE ... INCLUDING COMMENTS > * Allow table and index WITH options to be specified via hooks, for use > with plugins like GiST index methods --- ITAGAKI Takahiro wrote: > > Sim

Re: [HACKERS] Uncopied parameters on CREATE TABLE LIKE

2008-08-12 Thread ITAGAKI Takahiro
Simon Riggs <[EMAIL PROTECTED]> wrote: > On Tue, 2008-08-12 at 13:34 -0400, Bruce Momjian wrote: > > Is there a TODO here? > > Yes, three: > * create plugin API to allow extensible reloptions Yes, and some index access methods (gist and gin) should have abilities to handle reloptions in user d

Re: [HACKERS] Uncopied parameters on CREATE TABLE LIKE

2008-08-12 Thread Simon Riggs
On Tue, 2008-08-12 at 13:34 -0400, Bruce Momjian wrote: > Is there a TODO here? Yes, three: * create plugin API to allow extensible reloptions * allow reloptions to be copied when using INCLUDING DEFAULTS (if I got that right..) * allow new option to copy comments INCLUDING COMMENTS -- Simo

Re: [HACKERS] Uncopied parameters on CREATE TABLE LIKE

2008-08-12 Thread Bruce Momjian
Is there a TODO here? --- ITAGAKI Takahiro wrote: > > Simon Riggs <[EMAIL PROTECTED]> wrote: > > > On Thu, 2008-07-24 at 11:41 -0400, Tom Lane wrote: > > > > > Now, if you're suggesting we need a plugin hook somewhere in

Re: [HACKERS] Uncopied parameters on CREATE TABLE LIKE

2008-07-25 Thread ITAGAKI Takahiro
Simon Riggs <[EMAIL PROTECTED]> wrote: > On Thu, 2008-07-24 at 11:41 -0400, Tom Lane wrote: > > > Now, if you're suggesting we need a plugin hook somewhere in or around > > default_reloptions, that's possibly reasonable; but a GUC like you're > > suggesting seems quite pointless. > > OK, I'll h

Re: [HACKERS] Uncopied parameters on CREATE TABLE LIKE

2008-07-25 Thread Simon Riggs
On Thu, 2008-07-24 at 11:41 -0400, Tom Lane wrote: > Now, if you're suggesting we need a plugin hook somewhere in or around > default_reloptions, that's possibly reasonable; but a GUC like you're > suggesting seems quite pointless. OK, I'll have a look, or perhaps Itagaki? -- Simon Riggs

Re: [HACKERS] Uncopied parameters on CREATE TABLE LIKE

2008-07-24 Thread Tom Lane
Simon Riggs <[EMAIL PROTECTED]> writes: > I would prefer it if you had a plan to introduce user definable > parameters, similar to custom_variable_classes. Perhaps call this > "custom_table_options". So when we load a table and it has an option we > don't recognise we ignore it if it is one of the

Re: [HACKERS] Uncopied parameters on CREATE TABLE LIKE

2008-07-24 Thread Tom Lane
Simon Riggs <[EMAIL PROTECTED]> writes: > On Thu, 2008-07-24 at 10:30 -0400, Tom Lane wrote: >> Given the very short list of supported >> reloptions right now, why would you imagine that there will ever >> be such a thing as installation-local reloptions? > There's a ton of ways to introduce insta

Re: [HACKERS] Uncopied parameters on CREATE TABLE LIKE

2008-07-24 Thread Simon Riggs
On Thu, 2008-07-24 at 10:30 -0400, Tom Lane wrote: > Simon Riggs <[EMAIL PROTECTED]> writes: > > I would prefer it if you had a plan to introduce user definable > > parameters, similar to custom_variable_classes. Perhaps call this > > "custom_table_options". So when we load a table and it has an o

Re: [HACKERS] Uncopied parameters on CREATE TABLE LIKE

2008-07-24 Thread Simon Riggs
On Thu, 2008-07-24 at 19:09 +0900, ITAGAKI Takahiro wrote: > CREATE TABLE LIKE is useful to create a new partition from a template > table. We can use 3 options (INCLUDING DEFAULTS, CONSTRAINTS and INDEXES) > to copy more parameters from the template, but there are still some > uncopied parameters

[HACKERS] Uncopied parameters on CREATE TABLE LIKE

2008-07-24 Thread ITAGAKI Takahiro
CREATE TABLE LIKE is useful to create a new partition from a template table. We can use 3 options (INCLUDING DEFAULTS, CONSTRAINTS and INDEXES) to copy more parameters from the template, but there are still some uncopied parameters: 1. column storage parameters (toast options) 2. reloptions on