Re: [HACKERS] Unportable use of uname in pg_upgrade test script

2012-09-30 Thread Peter Eisentraut
On Sat, 2012-09-29 at 13:33 -0400, Andrew Dunstan wrote: > On 09/29/2012 01:06 PM, Tom Lane wrote: > > Andrew Dunstan writes: > >> The trouble with uname -s is that its output is a bit variable. I think > >> this will work: > >> testhost=`uname -a | sed 's/.* //'` > > What do you mean by "a

Re: [HACKERS] Unportable use of uname in pg_upgrade test script

2012-09-29 Thread Tom Lane
Andrew Dunstan writes: > Exactly, the sed script pulls the last token from the line, which is > Msys on all my Mingw systems. Perhaps that's "uname -v"? > If you want to do it another way we could possibly pass the PORTNAME > from the global make file. That might be safer. The last few words

Re: [HACKERS] Unportable use of uname in pg_upgrade test script

2012-09-29 Thread Andrew Dunstan
On 09/29/2012 01:06 PM, Tom Lane wrote: Andrew Dunstan writes: The trouble with uname -s is that its output is a bit variable. I think this will work: testhost=`uname -a | sed 's/.* //'` What do you mean by "a bit variable"? On one of my machines uname -s return MINGW32_NT5.1 On anot

Re: [HACKERS] Unportable use of uname in pg_upgrade test script

2012-09-29 Thread Tom Lane
Andrew Dunstan writes: > The trouble with uname -s is that its output is a bit variable. I think > this will work: > testhost=`uname -a | sed 's/.* //'` What do you mean by "a bit variable"? And why would that fix it? The output of -a is *defined* to be the same as -s followed by other s

Re: [HACKERS] Unportable use of uname in pg_upgrade test script

2012-09-29 Thread Andrew Dunstan
On 09/29/2012 12:13 PM, Tom Lane wrote: BTW, I tried the pg_upgrade regression tests this morning on my dinosaur HPUX box, and it promptly fell over with: uname: illegal option -- o usage: uname [-amnrsvil] [-S nodename] make: *** [check] Error 1 This is not terribly surprising, because the -o

[HACKERS] Unportable use of uname in pg_upgrade test script

2012-09-29 Thread Tom Lane
BTW, I tried the pg_upgrade regression tests this morning on my dinosaur HPUX box, and it promptly fell over with: uname: illegal option -- o usage: uname [-amnrsvil] [-S nodename] make: *** [check] Error 1 This is not terribly surprising, because the -o option is nowhere to be seen in the Single