Re: [HACKERS] Within CF app, "Bug Fixes" should be "Bug Fixes/Refactoring"

2015-11-07 Thread Peter Eisentraut
On 11/6/15 11:34 AM, Robert Haas wrote: > On Fri, Nov 6, 2015 at 12:52 AM, Michael Paquier > wrote: >>> I guess I'm wondering whether there's really enough of this to need >>> its own category. >> >> We have a category "Code comments" as well. Let's give it a shot so I

Re: [HACKERS] Within CF app, "Bug Fixes" should be "Bug Fixes/Refactoring"

2015-11-06 Thread Robert Haas
On Fri, Nov 6, 2015 at 12:52 AM, Michael Paquier wrote: >> I guess I'm wondering whether there's really enough of this to need >> its own category. > > We have a category "Code comments" as well. Let's give it a shot so I > am adding it. We could always remove it later

Re: [HACKERS] Within CF app, "Bug Fixes" should be "Bug Fixes/Refactoring"

2015-11-05 Thread Peter Geoghegan
On Thu, Oct 29, 2015 at 1:29 PM, Peter Geoghegan wrote: >> "Refactoring" seems rather a narrow definition of what might show up >> in such a category, btw. Maybe "Code Beautification" would be a >> suitable title? I'm bikeshedding though. > > I think that there is value in

Re: [HACKERS] Within CF app, "Bug Fixes" should be "Bug Fixes/Refactoring"

2015-11-05 Thread Robert Haas
On Thu, Nov 5, 2015 at 4:53 PM, Peter Geoghegan wrote: > On Thu, Oct 29, 2015 at 1:29 PM, Peter Geoghegan wrote: >>> "Refactoring" seems rather a narrow definition of what might show up >>> in such a category, btw. Maybe "Code Beautification" would be a >>>

Re: [HACKERS] Within CF app, "Bug Fixes" should be "Bug Fixes/Refactoring"

2015-11-05 Thread Michael Paquier
On Fri, Nov 6, 2015 at 1:47 PM, Robert Haas wrote: > On Thu, Nov 5, 2015 at 4:53 PM, Peter Geoghegan wrote: >> On Thu, Oct 29, 2015 at 1:29 PM, Peter Geoghegan wrote: "Refactoring" seems rather a narrow definition of what might show

[HACKERS] Within CF app, "Bug Fixes" should be "Bug Fixes/Refactoring"

2015-10-29 Thread Peter Geoghegan
I think that within the CF app, we should either rename the patch topic "Bug Fixes" to "Bug Fixes/Refactoring", or introduce a new "Refactoring" topic. I prefer the first approach. -- Peter Geoghegan -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your

Re: [HACKERS] Within CF app, "Bug Fixes" should be "Bug Fixes/Refactoring"

2015-10-29 Thread Michael Paquier
On Thu, Oct 29, 2015 at 8:33 PM, Peter Geoghegan wrote: > I think that within the CF app, we should either rename the patch > topic "Bug Fixes" to "Bug Fixes/Refactoring", or introduce a new > "Refactoring" topic. I prefer the first approach. I would vote for the second

Re: [HACKERS] Within CF app, "Bug Fixes" should be "Bug Fixes/Refactoring"

2015-10-29 Thread Mike Blackwell
​ On Thu, Oct 29, 2015 at 2:45 PM, Michael Paquier wrote: > On Thu, Oct 29, 2015 at 8:33 PM, Peter Geoghegan wrote: > > I think that within the CF app, we should either rename the patch > > topic "Bug Fixes" to "Bug Fixes/Refactoring", or introduce

Re: [HACKERS] Within CF app, "Bug Fixes" should be "Bug Fixes/Refactoring"

2015-10-29 Thread Tom Lane
Michael Paquier writes: > On Thu, Oct 29, 2015 at 8:33 PM, Peter Geoghegan wrote: >> I think that within the CF app, we should either rename the patch >> topic "Bug Fixes" to "Bug Fixes/Refactoring", or introduce a new >> "Refactoring" topic. I prefer

Re: [HACKERS] Within CF app, "Bug Fixes" should be "Bug Fixes/Refactoring"

2015-10-29 Thread Peter Geoghegan
On Thu, Oct 29, 2015 at 1:10 PM, Tom Lane wrote: > Ditto. Bug fixes are not at all like refactoring --- in particular, we'd > usually not consider refactoring as fit material for back-patching. > > "Refactoring" seems rather a narrow definition of what might show up > in such

Re: [HACKERS] Within CF app, "Bug Fixes" should be "Bug Fixes/Refactoring"

2015-10-29 Thread Josh Berkus
On 10/29/2015 01:10 PM, Tom Lane wrote: > Michael Paquier writes: >> On Thu, Oct 29, 2015 at 8:33 PM, Peter Geoghegan wrote: >>> I think that within the CF app, we should either rename the patch >>> topic "Bug Fixes" to "Bug Fixes/Refactoring", or