Re: [HACKERS] Wrong variable type in KeepLogSeg

2017-03-01 Thread Kyotaro HORIGUCHI
At Tue, 28 Feb 2017 12:21:01 +0100, Magnus Hagander wrote in magnus> > Hello, I found a variable definition with wrong type magnus> > specification in KeepLogSeg, which doesn't harm anything. magnus>

Re: [HACKERS] Wrong variable type in KeepLogSeg

2017-02-28 Thread Magnus Hagander
On Tue, Feb 28, 2017 at 3:17 AM, Kyotaro HORIGUCHI < horiguchi.kyot...@lab.ntt.co.jp> wrote: > Hello, I found a variable definition with wrong type > specification in KeepLogSeg, which doesn't harm anything. > > > static void > > KeepLogSeg(XLogRecPtr recptr, XLogSegNo *logSegNo) > > { > > ... >

Re: [HACKERS] Wrong variable type in KeepLogSeg

2017-02-27 Thread Kyotaro HORIGUCHI
At Tue, 28 Feb 2017 12:17:07 +0900, Michael Paquier wrote in > On Tue, Feb 28, 2017 at 11:17 AM, Kyotaro HORIGUCHI > wrote: > > slotSegNo should be a XLogSegNo. Both

Re: [HACKERS] Wrong variable type in KeepLogSeg

2017-02-27 Thread Michael Paquier
On Tue, Feb 28, 2017 at 11:17 AM, Kyotaro HORIGUCHI wrote: > slotSegNo should be a XLogSegNo. Both types share the same > intrinsic type so it doesn't harm anything. Nice catch! -- Michael -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)

[HACKERS] Wrong variable type in KeepLogSeg

2017-02-27 Thread Kyotaro HORIGUCHI
Hello, I found a variable definition with wrong type specification in KeepLogSeg, which doesn't harm anything. > static void > KeepLogSeg(XLogRecPtr recptr, XLogSegNo *logSegNo) > { > ... > /* then check whether slots limit removal further */ > if (max_replication_slots > 0 && keep !=