Re: [HACKERS] __attribute__ for non-gcc compilers

2015-03-11 Thread Andres Freund
Hi, On 2015-02-17 15:41:45 +0200, Oskari Saarenmaa wrote: Attached an updated patch rebased on today's git master that never defines aligned or packed empty. This is also included in the current commitfest, https://commitfest.postgresql.org/4/115/ I pushed a slightly modified (mostly moved

Re: [HACKERS] __attribute__ for non-gcc compilers

2015-02-23 Thread Oskari Saarenmaa
23.02.2015, 04:31, Robert Haas kirjoitti: On Tue, Feb 17, 2015 at 8:41 AM, Oskari Saarenmaa o...@ohmu.fi wrote: 15.01.2015, 21:58, Robert Haas kirjoitti: On Wed, Jan 14, 2015 at 5:54 PM, Andres Freund and...@2ndquadrant.com wrote: I think I'd for now simply not define pg_attribute_aligned()

Re: [HACKERS] __attribute__ for non-gcc compilers

2015-02-22 Thread Robert Haas
On Tue, Feb 17, 2015 at 8:41 AM, Oskari Saarenmaa o...@ohmu.fi wrote: 15.01.2015, 21:58, Robert Haas kirjoitti: On Wed, Jan 14, 2015 at 5:54 PM, Andres Freund and...@2ndquadrant.com wrote: I think I'd for now simply not define pg_attribute_aligned() on platforms where it's not supported,

Re: [HACKERS] __attribute__ for non-gcc compilers

2015-02-17 Thread Oskari Saarenmaa
17.02.2015, 15:46, Andres Freund kirjoitti: On 2015-02-17 15:41:45 +0200, Oskari Saarenmaa wrote: 15.01.2015, 21:58, Robert Haas kirjoitti: On Wed, Jan 14, 2015 at 5:54 PM, Andres Freund and...@2ndquadrant.com wrote: I think I'd for now simply not define pg_attribute_aligned() on platforms

Re: [HACKERS] __attribute__ for non-gcc compilers

2015-02-17 Thread Andres Freund
On 2015-02-17 15:41:45 +0200, Oskari Saarenmaa wrote: 15.01.2015, 21:58, Robert Haas kirjoitti: On Wed, Jan 14, 2015 at 5:54 PM, Andres Freund and...@2ndquadrant.com wrote: I think I'd for now simply not define pg_attribute_aligned() on platforms where it's not supported, instead of

Re: [HACKERS] __attribute__ for non-gcc compilers

2015-01-15 Thread Robert Haas
On Wed, Jan 14, 2015 at 5:54 PM, Andres Freund and...@2ndquadrant.com wrote: I think I'd for now simply not define pg_attribute_aligned() on platforms where it's not supported, instead of defining it empty. If we need a softer variant we can name it pg_attribute_aligned_if_possible or

Re: [HACKERS] __attribute__ for non-gcc compilers

2015-01-14 Thread Andres Freund
On 2015-01-14 17:46:39 -0500, Robert Haas wrote: On Wed, Jan 14, 2015 at 5:29 PM, Andres Freund and...@2ndquadrant.com wrote: I think it's better than the alternatives: a) Don't support 64bit atomics on any 32bit platform. I think that'd be sad because there's some places that could

Re: [HACKERS] __attribute__ for non-gcc compilers

2015-01-14 Thread Andres Freund
On 2015-01-14 15:48:47 -0500, Robert Haas wrote: On Tue, Jan 13, 2015 at 4:18 PM, Oskari Saarenmaa o...@ohmu.fi wrote: Commit db4ec2ffce35 added alignment attributes for 64-bit atomic variables as required on 32-bit platforms using __attribute__((aligned(8)). That works fine with GCC, and

Re: [HACKERS] __attribute__ for non-gcc compilers

2015-01-14 Thread Robert Haas
On Wed, Jan 14, 2015 at 5:29 PM, Andres Freund and...@2ndquadrant.com wrote: I think it's better than the alternatives: a) Don't support 64bit atomics on any 32bit platform. I think that'd be sad because there's some places that could greatly benefit from being able to

Re: [HACKERS] __attribute__ for non-gcc compilers

2015-01-14 Thread Oskari Saarenmaa
15.01.2015, 00:54, Andres Freund kirjoitti: I think I'd for now simply not define pg_attribute_aligned() on platforms where it's not supported, instead of defining it empty. If we need a softer variant we can name it pg_attribute_aligned_if_possible or something. Good point, all attributes