Re: [HACKERS] _bt_parent_deletion_safe() isn't safe

2010-07-03 Thread Alvaro Herrera
Excerpts from Tom Lane's message of vie jul 02 22:02:59 -0400 2010: > Possibly. I was planning to go back and study that code a bit more --- > I have a feeling that there might be some kind of rare concurrency bug > involved in btree page deletion. But I've been up to my rear in > other alligato

Re: [HACKERS] _bt_parent_deletion_safe() isn't safe

2010-07-02 Thread Tom Lane
Bruce Momjian writes: > Tom Lane wrote: >> A search of the archives produces no evidence that anyone has ever >> reported the "failed to delete rightmost child" error from the field. >> So while I still think this is a bug that needs to be fixed, it may >> be lower priority than I thought initiall

Re: [HACKERS] _bt_parent_deletion_safe() isn't safe

2010-07-02 Thread Bruce Momjian
Tom Lane wrote: > I wrote: > > I realized this while thinking about Jeff Amiel's report here: > > http://archives.postgresql.org/pgsql-general/2010-06/msg00351.php > > I can't prove that this is what's causing his crashes, but it could > > produce the symptom he's reporting. > > Actually, no it ca

Re: [HACKERS] _bt_parent_deletion_safe() isn't safe

2010-06-08 Thread Tom Lane
I wrote: > I realized this while thinking about Jeff Amiel's report here: > http://archives.postgresql.org/pgsql-general/2010-06/msg00351.php > I can't prove that this is what's causing his crashes, but it could > produce the symptom he's reporting. Actually, no it can't: the case I'm envisioning

[HACKERS] _bt_parent_deletion_safe() isn't safe

2010-06-08 Thread Tom Lane
The btree page deletion logic has a restriction that it cannot delete the rightmost child page of any non-leaf btree page (see nbtree/README for explanations). This is checked by _bt_parent_deletion_safe(), which claims * Note: it's OK to release page locks after checking, because a safe * dele