Re: [HACKERS] binary array and record recv

2009-01-27 Thread Alvaro Herrera
Tom Lane wrote: > Peter Eisentraut writes: > > On Tuesday 18 December 2007 18:30:22 Tom Lane wrote: > >> Arguably, pg_dump from an older version should make sure that the auto > >> rules should NOT get created, else it is failing to preserve an older > >> view's behavior. > > > We extend properti

Re: [HACKERS] binary array and record recv

2009-01-27 Thread Tom Lane
Peter Eisentraut writes: > On Tuesday 18 December 2007 18:30:22 Tom Lane wrote: >> Arguably, pg_dump from an older version should make sure that the auto >> rules should NOT get created, else it is failing to preserve an older >> view's behavior. > We extend properties of objects all the time. T

Re: [HACKERS] binary array and record recv

2009-01-27 Thread Peter Eisentraut
On Tuesday 27 January 2009 14:07:26 Peter Eisentraut wrote: > On Tuesday 18 December 2007 18:30:22 Tom Lane wrote: > > Arguably, pg_dump from an older version should make sure that the auto > > rules should NOT get created, else it is failing to preserve an older > > view's behavior. > > We extend

Re: [HACKERS] binary array and record recv

2009-01-27 Thread Peter Eisentraut
On Tuesday 18 December 2007 18:30:22 Tom Lane wrote: > Arguably, pg_dump from an older version should make sure that the auto > rules should NOT get created, else it is failing to preserve an older > view's behavior. We extend properties of objects all the time. That is why we make new releases.

Re: [HACKERS] binary array and record recv

2008-01-01 Thread Andrew Chernow
Tom Lane wrote: Andrew Chernow <[EMAIL PROTECTED]> writes: When dealing with binary, the Oid the client sends may match what the server thinks but the data is wrong (client sent binary formatted data of the wrong type). Thus, the only real check we saw was on the data length (which is rolling

Re: [HACKERS] binary array and record recv

2007-12-18 Thread Merlin Moncure
On Dec 18, 2007 11:30 AM, Tom Lane <[EMAIL PROTECTED]> wrote: > Andrew Chernow <[EMAIL PROTECTED]> writes: > > When dealing with binary, the Oid the client sends may match what the > > server thinks but the data is wrong (client sent binary formatted data > > of the wrong type). Thus, the only rea

Re: [HACKERS] binary array and record recv

2007-12-18 Thread Tom Lane
Andrew Chernow <[EMAIL PROTECTED]> writes: > When dealing with binary, the Oid the client sends may match what the > server thinks but the data is wrong (client sent binary formatted data > of the wrong type). Thus, the only real check we saw was on the data > length (which is rolling the dice)

Re: [HACKERS] binary array and record recv

2007-12-18 Thread Andrew Chernow
Tom Lane wrote: Andrew Chernow <[EMAIL PROTECTED]> writes: Both array and record binary recv functions require that the recv'd Oid match the Oid of what the backend has deduced. We don't think this behavior gets you very much. Other than the ability to detect errors before the code goes off

Re: [HACKERS] binary array and record recv

2007-12-18 Thread Tom Lane
Andrew Chernow <[EMAIL PROTECTED]> writes: > Both array and record binary recv functions require that the recv'd Oid > match the Oid of what the backend has deduced. We don't think this > behavior gets you very much. Other than the ability to detect errors before the code goes off into the weed

Re: [HACKERS] binary array and record recv

2007-12-18 Thread Andrew Chernow
>> PQlookupOid(PGconn *conn, char **type_names, Oid *oids, int count); We are backing away from this (not such a great idea). We are actually working hard at removing Oid dependencies from our PGparam idea. We think it is more generic to make the server allow InvalidOid for composites and ar

[HACKERS] binary array and record recv

2007-12-18 Thread Andrew Chernow
Both array and record binary recv functions require that the recv'd Oid match the Oid of what the backend has deduced. We don't think this behavior gets you very much. The backend apparently knows the Oid of a composite or array elemtype, so if the sender chooses to send InvalidOid why should