Re: [HACKERS] bug: json format and auto_explain

2009-12-07 Thread Alvaro Herrera
Tom Lane wrote: Euler Taveira de Oliveira eu...@timbira.com writes: While testing the EXPLAIN BUFFERS patch I found a bug. I'm too tired to provide a fix right now but if someone can take it I will appreciate. It seems ExplainJSONLineEnding() doesn't expect es-grouping_stack list as a

Re: [HACKERS] bug: json format and auto_explain

2009-12-07 Thread Euler Taveira de Oliveira
Alvaro Herrera escreveu: Fortunately the author of auto_explain can now commit the fix by himself ... Kudos, BTW :-) Congratulations! -- Euler Taveira de Oliveira http://www.timbira.com/ -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your

Re: [HACKERS] bug: json format and auto_explain

2009-12-07 Thread Tom Lane
Itagaki Takahiro itagaki.takah...@oss.ntt.co.jp writes: Tom Lane t...@sss.pgh.pa.us wrote: Looks like auto_explain is under the illusion that it need not call ExplainBeginOutput/ExplainEndOutput. Explain{Begin/End}Output are static functions, so we cannot call them from an external contrib

Re: [HACKERS] bug: json format and auto_explain

2009-12-07 Thread Robert Haas
On Mon, Dec 7, 2009 at 10:42 AM, Alvaro Herrera alvhe...@commandprompt.com wrote: Tom Lane wrote: Euler Taveira de Oliveira eu...@timbira.com writes: While testing the EXPLAIN BUFFERS patch I found a bug. I'm too tired to provide a fix right now but if someone can take it I will appreciate.

Re: [HACKERS] bug: json format and auto_explain

2009-12-07 Thread Robert Haas
On Mon, Dec 7, 2009 at 11:07 AM, Tom Lane t...@sss.pgh.pa.us wrote: Itagaki Takahiro itagaki.takah...@oss.ntt.co.jp writes: Tom Lane t...@sss.pgh.pa.us wrote: Looks like auto_explain is under the illusion that it need not call ExplainBeginOutput/ExplainEndOutput. Explain{Begin/End}Output are

Re: [HACKERS] bug: json format and auto_explain

2009-12-07 Thread Tom Lane
Robert Haas robertmh...@gmail.com writes: There's an awful lot of layers of function calls happening in explain.c for no really discernable purpose that I can see. ExplainOneQuery() calls either ExplainOneUtility() if it has a utility command or ExplainOneQuery_hook() if that's defined or else

[HACKERS] bug: json format and auto_explain

2009-12-06 Thread Euler Taveira de Oliveira
Hi, While testing the EXPLAIN BUFFERS patch I found a bug. I'm too tired to provide a fix right now but if someone can take it I will appreciate. It seems ExplainJSONLineEnding() doesn't expect es-grouping_stack list as a null pointer. eu...@harman $ ./install/bin/psql psql (8.5devel) Type help

Re: [HACKERS] bug: json format and auto_explain

2009-12-06 Thread Tom Lane
Euler Taveira de Oliveira eu...@timbira.com writes: While testing the EXPLAIN BUFFERS patch I found a bug. I'm too tired to provide a fix right now but if someone can take it I will appreciate. It seems ExplainJSONLineEnding() doesn't expect es-grouping_stack list as a null pointer. Looks

Re: [HACKERS] bug: json format and auto_explain

2009-12-06 Thread Itagaki Takahiro
Tom Lane t...@sss.pgh.pa.us wrote: Looks like auto_explain is under the illusion that it need not call ExplainBeginOutput/ExplainEndOutput. They were added by XML formatter; I suppose it worked on 8.4. Explain{Begin/End}Output are static functions, so we cannot call them from an external