Re: [HACKERS] chomp PQerrorMessage() in backend uses

2017-02-27 Thread Peter Eisentraut
On 2/8/17 11:00, Tom Lane wrote: > Peter Eisentraut writes: >> Here is a patch to systematically trim the trailing newlines off >> PQerrorMessage() results in backend uses (dblink, postgres_fdw, >> libpqwalreceiver). > > +1 committed >> I noticed that there are some inconsistent assumptions abo

Re: [HACKERS] chomp PQerrorMessage() in backend uses

2017-02-08 Thread Tom Lane
Peter Eisentraut writes: > Here is a patch to systematically trim the trailing newlines off > PQerrorMessage() results in backend uses (dblink, postgres_fdw, > libpqwalreceiver). +1 > I noticed that there are some inconsistent assumptions about whether > PQerrorMessage() can ever return NULL. F

[HACKERS] chomp PQerrorMessage() in backend uses

2017-02-08 Thread Peter Eisentraut
Here is a patch to systematically trim the trailing newlines off PQerrorMessage() results in backend uses (dblink, postgres_fdw, libpqwalreceiver). I noticed that there are some inconsistent assumptions about whether PQerrorMessage() can ever return NULL. From the code, I think that should not be