Re: [HACKERS] close_ps, NULLs, and DirectFunctionCall

2017-09-22 Thread Robert Haas
On Wed, Sep 20, 2017 at 4:25 PM, Andrew Gierth wrote: > postgres=# select point(1,2) ## '((0,0),(NaN,NaN))'::box; > ERROR: function 0x9c5de0 returned NULL > > postgres=# select point(1,2) <-> '((0,0),(NaN,NaN))'::box; > ERROR: function 0x9c5de0 returned NULL > >

Re: [HACKERS] close_ps, NULLs, and DirectFunctionCall

2017-09-21 Thread Emre Hasegeli
> Does this need fixing, and if so how? My improve geometric types patch [1] fixes this issue, by cosidering NaNs larger than any non-NAN same as the float types. There are many issues with the geometric types similar to this. Let's combine our efforts to put them into a shape. [1]

[HACKERS] close_ps, NULLs, and DirectFunctionCall

2017-09-20 Thread Andrew Gierth
(From IRC discussion with Andreas about some sqlsmith errors) Commit 278148907a9 changed close_ps in geo_ops.c to return SQL NULL in the event that a valid result point was not found (rather than crashing or failing an assert). But close_ps is called with DirectFunctionCall from other close_*