Petr Jelinek writes:
> On 05/05/17 16:56, Tom Lane wrote:
>> So the comment should be something like "if the column is unchanged,
>> we should not attempt to access its value beyond this point. To
>> help catch any such attempts, set the string to NULL" ?
> Yes that sounds about right. We don't
On 05/05/17 16:56, Tom Lane wrote:
> Petr Jelinek writes:
>> On 05/05/17 06:50, Tom Lane wrote:
>>> Actually, looking around a bit there, it's not even clear why
>>> we should be booby-trapping the value of an unchanged column in
>>> the first place. So I'd say that not only is the code dubious
>
Petr Jelinek writes:
> On 05/05/17 06:50, Tom Lane wrote:
>> Actually, looking around a bit there, it's not even clear why
>> we should be booby-trapping the value of an unchanged column in
>> the first place. So I'd say that not only is the code dubious
>> but the comment is inadequate too.
> H
On 05/05/17 06:50, Tom Lane wrote:
> Haribabu Kommi writes:
>> I am getting a compiler warning when I build the latest HEAD PostgreSQL with
>> visual studio 2017.
>> The code at the line is,
>> tuple->values[i] = (char *) (Size)0xdeadbeef; /* make bad usage more obvious
>> */
>
> Yeah, you're no
Haribabu Kommi writes:
> I am getting a compiler warning when I build the latest HEAD PostgreSQL with
> visual studio 2017.
> The code at the line is,
> tuple->values[i] = (char *) (Size)0xdeadbeef; /* make bad usage more obvious
> */
Yeah, you're not the first to complain about this. To my min
I am getting a compiler warning when I build the latest HEAD PostgreSQL with
visual studio 2017.
src/backend/replication/logical/proto.c(482): warning C4312: 'type cast':
conversion from 'unsigned int' to 'char *' of greater size
Details of the warning is available in the link [1].
The code at t
