Jeff Davis writes:
> I think I see how this fixes the problem, but I still don't completely
> understand.
> Why can't we just make a real copy of the tuple descriptor for the type
> cache entry, rather than sharing it between the relcache and the type
> cache?
The issue isn't really about whethe
On Wed, 2010-09-01 at 20:57 -0400, Tom Lane wrote:
> I wrote:
> > Probably the best fix would be to make typcache flushing fully
> > independent of the relcache, but that would mean making sure that all
> > ALTER TABLE variants that affect the rowtype will issue an explicit
> > typcache flush. Tha
I wrote:
> Probably the best fix would be to make typcache flushing fully
> independent of the relcache, but that would mean making sure that all
> ALTER TABLE variants that affect the rowtype will issue an explicit
> typcache flush. That seems a bit too invasive to be back-patchable.
> I'm not en
Jeff Davis writes:
> I have attached regression.diffs after a "make check". The diffs don't
> look trivial, and actually look quite strange to me.
BTW, if I dike out the flush_rowtype_cache call at relcache.c:1929,
the regression tests do pass for me, so it seems there is only one
bug exposed by
I wrote:
> Jeff Davis writes:
>> I have attached regression.diffs after a "make check". The diffs don't
>> look trivial, and actually look quite strange to me.
> Hmm, sorta looks like that breaks something related to checking for
> composite types. That would be a bug. Will look.
So here is th
Jeff Davis writes:
> On Wed, 2010-09-01 at 15:31 -0400, Tom Lane wrote:
>> Jeff Davis writes:
>>> Compiling with RELCACHE_FORCE_RELEASE doesn't pass "make check" on my
>>> machine.
>> What happens exactly?
> I have attached regression.diffs after a "make check". The diffs don't
> look trivial,
Jeff Davis writes:
> Compiling with RELCACHE_FORCE_RELEASE doesn't pass "make check" on my
> machine.
What happens exactly?
> Is it supposed to pass?
It shouldn't crash, but I'm not certain whether you'd see any
visible diffs in the tests.
regards, tom lane
--
Sent vi
Compiling with RELCACHE_FORCE_RELEASE doesn't pass "make check" on my
machine.
Is it supposed to pass?
Regards,
Jeff Davis
--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers
