On Tue, Aug 11, 2009 at 9:56 PM, Tom Lanet...@sss.pgh.pa.us wrote:
Robert Haas robertmh...@gmail.com writes:
Given that the anum.h stuff is gone, vastly might be an
overstatement. I'm pretty surprised to find out that people don't
like the idea of having dependencies be correct from anywhere
On Sunday 28 June 2009 21:21:35 Robert Haas wrote:
I think that our dependencies for generated header files (gram.h,
fmgroids.h, probes.h) are not as good as they could be. What we do
right now is make src/backend/Makefile rebuild these before recursing
through its subdirectories. This works
On Tue, Aug 11, 2009 at 4:38 PM, Peter Eisentrautpete...@gmx.net wrote:
On Sunday 28 June 2009 21:21:35 Robert Haas wrote:
I think that our dependencies for generated header files (gram.h,
fmgroids.h, probes.h) are not as good as they could be. What we do
right now is make
Robert Haas escribió:
*shrug* You don't have to accept the patch, but I'm unclear as to how
make from a subdirectory will ever work reliably without something
like this. The problem occurs when .c files have dependencies on
files that are generated by a Makefile in some other subdirectory.
Robert Haas robertmh...@gmail.com writes:
On Tue, Aug 11, 2009 at 4:38 PM, Peter Eisentrautpete...@gmx.net wrote:
I'm not convinced by this use case.
Well, my original motivation for developing this patch was that I
often go into a subdirectory and start hacking on a .c file and then
type
On Tue, Aug 11, 2009 at 9:00 PM, Tom Lanet...@sss.pgh.pa.us wrote:
Robert Haas robertmh...@gmail.com writes:
On Tue, Aug 11, 2009 at 4:38 PM, Peter Eisentrautpete...@gmx.net wrote:
I'm not convinced by this use case.
Well, my original motivation for developing this patch was that I
often go
On Tue, Aug 11, 2009 at 5:56 PM, Alvaro
Herreraalvhe...@commandprompt.com wrote:
Robert Haas escribió:
*shrug* You don't have to accept the patch, but I'm unclear as to how
make from a subdirectory will ever work reliably without something
like this. The problem occurs when .c files have
Robert Haas robertmh...@gmail.com writes:
On Tue, Aug 11, 2009 at 9:00 PM, Tom Lanet...@sss.pgh.pa.us wrote:
Surely the answer to that is you should be configuring with
--enable-depend.
Uhm, the point is that this is broken even with ---enable-depend.
Oh, okay, but that's only for
Robert Haas escribió:
Given that the anum.h stuff is gone, vastly might be an
overstatement. I'm pretty surprised to find out that people don't
like the idea of having dependencies be correct from anywhere in the
tree. Even if I'm the only developer who does partial builds, the
cost seems
Robert Haas robertmh...@gmail.com writes:
Given that the anum.h stuff is gone, vastly might be an
overstatement. I'm pretty surprised to find out that people don't
like the idea of having dependencies be correct from anywhere in the
tree. Even if I'm the only developer who does partial
On Tue, Aug 11, 2009 at 9:19 PM, Tom Lanet...@sss.pgh.pa.us wrote:
Robert Haas robertmh...@gmail.com writes:
On Tue, Aug 11, 2009 at 9:00 PM, Tom Lanet...@sss.pgh.pa.us wrote:
Surely the answer to that is you should be configuring with
--enable-depend.
Uhm, the point is that this is broken
On Wed, Jul 29, 2009 at 9:28 AM, Robert Haasrobertmh...@gmail.com wrote:
On Wed, Jul 29, 2009 at 8:43 AM, Peter Eisentrautpete...@gmx.net wrote:
On Sunday 28 June 2009 21:21:35 Robert Haas wrote:
I think that our dependencies for generated header files (gram.h,
fmgroids.h, probes.h) are not as
Robert Haas escribió:
Is it conceivable that there might be a dependency on one of the
generated header files from someplace in src other than src/backend?
If so, it seems like that might be an argument for leaving it as I had
it.
Well, plperl.c includes fmgroids.h.
--
Alvaro Herrera
On Sunday 28 June 2009 21:21:35 Robert Haas wrote:
I think that our dependencies for generated header files (gram.h,
fmgroids.h, probes.h) are not as good as they could be. What we do
right now is make src/backend/Makefile rebuild these before recursing
through its subdirectories. This works
On Wed, Jul 29, 2009 at 8:43 AM, Peter Eisentrautpete...@gmx.net wrote:
On Sunday 28 June 2009 21:21:35 Robert Haas wrote:
I think that our dependencies for generated header files (gram.h,
fmgroids.h, probes.h) are not as good as they could be. What we do
right now is make
Robert Haas escribió:
Woops. It seems that patch generates some warnings on a vpath build
which I failed to notice. Corrected version that guards against same
is attached.
Interestingly, this patch causes diffstat (at least my version of it) to
attribute the line additions to
Hi,
I think that our dependencies for generated header files (gram.h,
fmgroids.h, probes.h) are not as good as they could be. What we do
right now is make src/backend/Makefile rebuild these before recursing
through its subdirectories. This works OK for a top-level make, but
if you run make
On Sun, Jun 28, 2009 at 2:21 PM, Robert Haasrobertmh...@gmail.com wrote:
I think that our dependencies for generated header files (gram.h,
fmgroids.h, probes.h) are not as good as they could be. What we do
right now is make src/backend/Makefile rebuild these before recursing
through its
18 matches
Mail list logo