Re: [HACKERS] dropping table in testcase alter_table.sql

2011-07-12 Thread Ashutosh Bapat
On Wed, Jul 13, 2011 at 2:53 AM, Peter Eisentraut wrote: > On tis, 2011-07-12 at 08:51 -0400, Tom Lane wrote: > > Peter Eisentraut writes: > > > It has occurred to me a few times that it could be useful to clarify > the > > > approach here. If we could somehow have a separable cleanup step for

Re: [HACKERS] dropping table in testcase alter_table.sql

2011-07-12 Thread Peter Eisentraut
On tis, 2011-07-12 at 08:51 -0400, Tom Lane wrote: > Peter Eisentraut writes: > > It has occurred to me a few times that it could be useful to clarify the > > approach here. If we could somehow have a separable cleanup step for > > every test, and eliminate interdependencies between tests, we cou

Re: [HACKERS] dropping table in testcase alter_table.sql

2011-07-12 Thread Tom Lane
Peter Eisentraut writes: > It has occurred to me a few times that it could be useful to clarify the > approach here. If we could somehow have a separable cleanup step for > every test, and eliminate interdependencies between tests, we could more > easily support a number of uses cases such as cre

Re: [HACKERS] dropping table in testcase alter_table.sql

2011-07-12 Thread Robert Haas
On Jul 12, 2011, at 4:46 AM, Peter Eisentraut wrote: > On fre, 2011-07-08 at 22:27 -0400, Robert Haas wrote: >> On Fri, Jul 8, 2011 at 1:45 AM, Ashutosh Bapat >> wrote: >>> I think, tab1 and tab2 are too common names, for anyone to pick up for the >>> tables. Also, the test alter_table.sql is dro

Re: [HACKERS] dropping table in testcase alter_table.sql

2011-07-12 Thread Peter Eisentraut
On fre, 2011-07-08 at 22:27 -0400, Robert Haas wrote: > On Fri, Jul 8, 2011 at 1:45 AM, Ashutosh Bapat > wrote: > > I think, tab1 and tab2 are too common names, for anyone to pick up for the > > tables. Also, the test alter_table.sql is dropping many other tables (even > > those which have undergo

Re: [HACKERS] dropping table in testcase alter_table.sql

2011-07-08 Thread Robert Haas
On Fri, Jul 8, 2011 at 1:45 AM, Ashutosh Bapat wrote: > I think, tab1 and tab2 are too common names, for anyone to pick up for the > tables. Also, the test alter_table.sql is dropping many other tables (even > those which have undergone renaming), then why not these two? Beats me, but I don't see

Re: [HACKERS] dropping table in testcase alter_table.sql

2011-07-07 Thread Ashutosh Bapat
On Thu, Jul 7, 2011 at 9:41 PM, Robert Haas wrote: > On Thu, Jul 7, 2011 at 3:05 AM, Ashutosh Bapat > wrote: > > I noticed that the test alter_table.sql is creating two tables tab1 and > tab2 > > and it's not dropping it. Any test which follows this test and tries to > > create tables with names

Re: [HACKERS] dropping table in testcase alter_table.sql

2011-07-07 Thread Robert Haas
On Thu, Jul 7, 2011 at 3:05 AM, Ashutosh Bapat wrote: > I noticed that the test alter_table.sql is creating two tables tab1 and tab2 > and it's not dropping it. Any test which follows this test and tries to > create tables with names tab1 and tab2 will fail (unless it drops those > tables first, b

[HACKERS] dropping table in testcase alter_table.sql

2011-07-07 Thread Ashutosh Bapat
Hi, I noticed that the test alter_table.sql is creating two tables tab1 and tab2 and it's not dropping it. Any test which follows this test and tries to create tables with names tab1 and tab2 will fail (unless it drops those tables first, but that may not work, since tab2.y depends upon tab1 in alt