Re: [HACKERS] exit_horribly vs exit_nicely in pg_dump

2014-03-05 Thread Bruce Momjian
On Wed, Nov 6, 2013 at 08:47:43AM -0500, Peter Eisentraut wrote: On 11/5/13, 8:46 AM, Pavel Golub wrote: I suppose this should be call to exit_nicely() for all possible cases. The only need for calling exit_horribly() is when we are deep down in the multithreaded code, AFAIK. Doesn't

Re: [HACKERS] exit_horribly vs exit_nicely in pg_dump

2013-11-06 Thread Peter Eisentraut
On 11/5/13, 8:46 AM, Pavel Golub wrote: I suppose this should be call to exit_nicely() for all possible cases. The only need for calling exit_horribly() is when we are deep down in the multithreaded code, AFAIK. Doesn't hurt either, though. But it would be OK to make this more consistent.

[HACKERS] exit_horribly vs exit_nicely in pg_dump

2013-11-05 Thread Pavel Golub
Hello. Examining pg_dump sources recently I've found that different exit procedure used for the same situations. A quick example from pg_dump.c: if (dataOnly schemaOnly) exit_horribly(NULL, options -s/--schema-only and -a/--data-only cannot be used together\n);