Re: [HACKERS] folder:lk/lk date:yesterday..

2014-05-05 Thread Heikki Linnakangas
On 04/30/2014 06:39 PM, Andres Freund wrote: Hi, Coverity flagged a couple of issues that seem to worth addressing by changing the code instead of ignoring them: 01) heap_xlog_update() looks to coverity as if it could trigger a NULL pointer dereference. That's because it thinks that oldtup

Re: [HACKERS] folder:lk/lk date:yesterday..

2014-04-30 Thread Andres Freund
On 2014-04-30 17:39:27 +0200, Andres Freund wrote: > Hi, > > Coverity flagged a couple of issues that seem to worth addressing by > changing the code instead of ignoring them: > > 01) heap_xlog_update() looks to coverity as if it could trigger a NULL > pointer dereference. That's because it t

[HACKERS] folder:lk/lk date:yesterday..

2014-04-30 Thread Andres Freund
Hi, Coverity flagged a couple of issues that seem to worth addressing by changing the code instead of ignoring them: 01) heap_xlog_update() looks to coverity as if it could trigger a NULL pointer dereference. That's because it thinks that oldtup.t_data is NULL if XLR_BKP_BLOCK(0) while re