Re: [HACKERS] formatting.c

2014-09-13 Thread Bruce Momjian
On Fri, Sep 12, 2014 at 11:48:03PM -0400, Tom Lane wrote: > Bruce Momjian writes: > > Is everyone OK with me renaming some variables, structures, and macros? > > It will make back-patching harder, but will allow us to properly maintain > > that file. > > The back-patching problem could be addres

Re: [HACKERS] formatting.c

2014-09-12 Thread Tom Lane
Bruce Momjian writes: > Is everyone OK with me renaming some variables, structures, and macros? > It will make back-patching harder, but will allow us to properly maintain > that file. The back-patching problem could be addressed by back-patching the renaming. If it's purely a mechanical thing,

[HACKERS] formatting.c

2014-09-12 Thread Bruce Momjian
I am researching some problems with formatting.c, and I now see that the naming of things makes the code pretty incomprehensible. Is everyone OK with me renaming some variables, structures, and macros? It will make back-patching harder, but will allow us to properly maintain that file. Right now