Re: [HACKERS] gcc 4.3 breaks ContribCheck in 8.2 and older.

2008-03-26 Thread Kurt Roeckx
On Tue, Mar 25, 2008 at 06:03:39PM -0400, Andrew Dunstan wrote: Patches committed, please re-enable the back branches so we can see what happens. I have tested this back as far as 8.0, and all seems OK. 7.4 passed too. Kurt -- Sent via pgsql-hackers mailing list

Re: [HACKERS] gcc 4.3 breaks ContribCheck in 8.2 and older.

2008-03-25 Thread Kurt Roeckx
On Mon, Mar 24, 2008 at 05:59:33PM -0400, Tom Lane wrote: Kurt Roeckx [EMAIL PROTECTED] writes: I did try the patch. It fails just the same way. Hmph. So we still don't know why 8.2 and 8.3 behave differently ... [ pokes around ... ] Hah, maybe this is it:

Re: [HACKERS] gcc 4.3 breaks ContribCheck in 8.2 and older.

2008-03-25 Thread Tom Lane
Kurt Roeckx [EMAIL PROTECTED] writes: On Mon, Mar 24, 2008 at 05:59:33PM -0400, Tom Lane wrote: http://archives.postgresql.org/pgsql-committers/2007-03/msg00292.php This patch atleast solves the problems with 8.2. Excellent, I'll go back-patch that and we can see what else there is. You still

Re: [HACKERS] gcc 4.3 breaks ContribCheck in 8.2 and older.

2008-03-25 Thread Kurt Roeckx
On Tue, Mar 25, 2008 at 02:11:30PM -0400, Tom Lane wrote: Kurt Roeckx [EMAIL PROTECTED] writes: On Mon, Mar 24, 2008 at 05:59:33PM -0400, Tom Lane wrote: http://archives.postgresql.org/pgsql-committers/2007-03/msg00292.php This patch atleast solves the problems with 8.2. Excellent,

Re: [HACKERS] gcc 4.3 breaks ContribCheck in 8.2 and older.

2008-03-25 Thread Tom Lane
Kurt Roeckx [EMAIL PROTECTED] writes: On Tue, Mar 25, 2008 at 02:11:30PM -0400, Tom Lane wrote: Excellent, I'll go back-patch that and we can see what else there is. You still have panda set up to build with gcc 4.3, correct? Yes, I just disabled some cron jobs for those that failed. Patches

Re: [HACKERS] gcc 4.3 breaks ContribCheck in 8.2 and older.

2008-03-25 Thread Andrew Dunstan
Tom Lane wrote: Kurt Roeckx [EMAIL PROTECTED] writes: On Tue, Mar 25, 2008 at 02:11:30PM -0400, Tom Lane wrote: Excellent, I'll go back-patch that and we can see what else there is. You still have panda set up to build with gcc 4.3, correct? Yes, I just disabled some

Re: [HACKERS] gcc 4.3 breaks ContribCheck in 8.2 and older.

2008-03-24 Thread Kurt Roeckx
On Thu, Mar 20, 2008 at 06:53:27PM -0400, Tom Lane wrote: Kurt Roeckx [EMAIL PROTECTED] writes: I did some tests with gcc 4.3 on the branches from 7.4 to 8.3 and head. 8.3 and head don't have a problem. All others failed in the ContribCheck state. You can see the results on buildfarm

Re: [HACKERS] gcc 4.3 breaks ContribCheck in 8.2 and older.

2008-03-24 Thread Alvaro Herrera
Kurt Roeckx wrote: On Thu, Mar 20, 2008 at 06:53:27PM -0400, Tom Lane wrote: Kurt Roeckx [EMAIL PROTECTED] writes: I did some tests with gcc 4.3 on the branches from 7.4 to 8.3 and head. 8.3 and head don't have a problem. All others failed in the ContribCheck state. Bizarre.

Re: [HACKERS] gcc 4.3 breaks ContribCheck in 8.2 and older.

2008-03-24 Thread Kurt Roeckx
On Mon, Mar 24, 2008 at 02:05:14PM -0300, Alvaro Herrera wrote: Kurt Roeckx wrote: On Thu, Mar 20, 2008 at 06:53:27PM -0400, Tom Lane wrote: Kurt Roeckx [EMAIL PROTECTED] writes: I did some tests with gcc 4.3 on the branches from 7.4 to 8.3 and head. 8.3 and head don't have a

Re: [HACKERS] gcc 4.3 breaks ContribCheck in 8.2 and older.

2008-03-24 Thread Alvaro Herrera
Kurt Roeckx wrote: No, this has nothing to do with CFLAGS. It's calling a function which returns something other than it actually returns. Yeah but apparently gcc 4.3 is working in 8.3 and later. What happens to your sample program if you compile it with the CFLAGS used in 8.3 versus those

Re: [HACKERS] gcc 4.3 breaks ContribCheck in 8.2 and older.

2008-03-24 Thread Andrew Dunstan
Alvaro Herrera wrote: Kurt Roeckx wrote: No, this has nothing to do with CFLAGS. It's calling a function which returns something other than it actually returns. Yeah but apparently gcc 4.3 is working in 8.3 and later. What happens to your sample program if you compile it with the

Re: [HACKERS] gcc 4.3 breaks ContribCheck in 8.2 and older.

2008-03-24 Thread Kurt Roeckx
On Mon, Mar 24, 2008 at 03:05:31PM -0300, Alvaro Herrera wrote: Kurt Roeckx wrote: No, this has nothing to do with CFLAGS. It's calling a function which returns something other than it actually returns. Yeah but apparently gcc 4.3 is working in 8.3 and later. What happens to your

Re: [HACKERS] gcc 4.3 breaks ContribCheck in 8.2 and older.

2008-03-24 Thread Tom Lane
Kurt Roeckx [EMAIL PROTECTED] writes: 8.2 and 8.3 actually get the same value in fmgr_oldstyle(), it just seems they do something else with it somewhere else. Doh. I'll bet the difference is this fix: http://archives.postgresql.org/pgsql-committers/2007-07/msg00131.php Please try that patch

Re: [HACKERS] gcc 4.3 breaks ContribCheck in 8.2 and older.

2008-03-24 Thread Kurt Roeckx
On Mon, Mar 24, 2008 at 02:52:18PM -0400, Tom Lane wrote: Kurt Roeckx [EMAIL PROTECTED] writes: 8.2 and 8.3 actually get the same value in fmgr_oldstyle(), it just seems they do something else with it somewhere else. Doh. I'll bet the difference is this fix:

Re: [HACKERS] gcc 4.3 breaks ContribCheck in 8.2 and older.

2008-03-24 Thread Tom Lane
Kurt Roeckx [EMAIL PROTECTED] writes: On Mon, Mar 24, 2008 at 02:52:18PM -0400, Tom Lane wrote: Please try that patch and see what it fixes pre-8.3. No, returnValue contains the same value for both 8.2 and 8.3. There is no reason why casting from a char * to a char * should result into

Re: [HACKERS] gcc 4.3 breaks ContribCheck in 8.2 and older.

2008-03-24 Thread Kurt Roeckx
On Mon, Mar 24, 2008 at 03:52:09PM -0400, Tom Lane wrote: Kurt Roeckx [EMAIL PROTECTED] writes: On Mon, Mar 24, 2008 at 02:52:18PM -0400, Tom Lane wrote: Please try that patch and see what it fixes pre-8.3. No, returnValue contains the same value for both 8.2 and 8.3. There is no

Re: [HACKERS] gcc 4.3 breaks ContribCheck in 8.2 and older.

2008-03-24 Thread Tom Lane
Kurt Roeckx [EMAIL PROTECTED] writes: I did try the patch. It fails just the same way. Hmph. So we still don't know why 8.2 and 8.3 behave differently ... [ pokes around ... ] Hah, maybe this is it: http://archives.postgresql.org/pgsql-committers/2007-03/msg00292.php

Re: [HACKERS] gcc 4.3 breaks ContribCheck in 8.2 and older.

2008-03-24 Thread Kurt Roeckx
On Mon, Mar 24, 2008 at 05:59:33PM -0400, Tom Lane wrote: Kurt Roeckx [EMAIL PROTECTED] writes: I did try the patch. It fails just the same way. Hmph. So we still don't know why 8.2 and 8.3 behave differently ... [ pokes around ... ] Hah, maybe this is it:

Re: [HACKERS] gcc 4.3 breaks ContribCheck in 8.2 and older.

2008-03-23 Thread Kurt Roeckx
On Thu, Mar 20, 2008 at 06:53:27PM -0400, Tom Lane wrote: Kurt Roeckx [EMAIL PROTECTED] writes: I did some tests with gcc 4.3 on the branches from 7.4 to 8.3 and head. 8.3 and head don't have a problem. All others failed in the ContribCheck state. You can see the results on buildfarm

[HACKERS] gcc 4.3 breaks ContribCheck in 8.2 and older.

2008-03-20 Thread Kurt Roeckx
Hi, I did some tests with gcc 4.3 on the branches from 7.4 to 8.3 and head. 8.3 and head don't have a problem. All others failed in the ContribCheck state. You can see the results on buildfarm member panda. Kurt -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make

Re: [HACKERS] gcc 4.3 breaks ContribCheck in 8.2 and older.

2008-03-20 Thread Tom Lane
Kurt Roeckx [EMAIL PROTECTED] writes: I did some tests with gcc 4.3 on the branches from 7.4 to 8.3 and head. 8.3 and head don't have a problem. All others failed in the ContribCheck state. You can see the results on buildfarm member panda. Bizarre. There doesn't seem to be any significant