Re: [HACKERS] gist picksplit iteration

2010-10-06 Thread Dimitri Fontaine
Marios Vodas writes: > I would expect it to start from 0, since C arrays are 0 based. > So my question is why does this happen? Well I don't have any good answer other than "it's the API". Time to have a look at some contrib code and some other, maybe, like ip4r or prefix (the former is fixed si

[HACKERS] gist picksplit iteration

2010-10-05 Thread Marios Vodas
At this page in documentation http://www.postgresql.org/docs/9.0/static/gist-implementation.html and under "picksplit" the loop that iterates through entryvec->vector[] starts from 1 (since FirstOffsetNumber equals 1). for (i = FirstOffsetNumber; i <= maxoff; i = OffsetNumberNext(i)) I would expec