Re: [HACKERS] git diff --patience

2010-10-01 Thread Greg Stark
On Fri, Oct 1, 2010 at 7:15 AM, Kevin Grittner wrote: > An interesting exercise it so think about what > real-life lines you could have which would have multiple occurrences > in this pattern, and think about whether you would then prefer the > --patience output, especially if this were part of a

Re: [HACKERS] git diff --patience

2010-10-01 Thread Kevin Grittner
Gurjeet Singh wrote: > Alvaro Herrera wrote: >> There is a very simple example posted on some of the blog posts >> that goes something like >> >> >> >> >> >> >> >> xyz >> >> and the "xyz" is moved to the front. In this corner case, the >> pa

Re: [HACKERS] git diff --patience

2010-10-01 Thread Gurjeet Singh
On Fri, Oct 1, 2010 at 9:38 AM, Alvaro Herrera wrote: > Excerpts from Kevin Grittner's message of jue sep 30 16:38:11 -0400 2010: > > > When I read the description of the algorithm, I can't imagine a > > situation where --patience would make the diff *worse*. I was > > somewhat afraid (based on t

Re: [HACKERS] git diff --patience

2010-10-01 Thread Alvaro Herrera
Excerpts from Kevin Grittner's message of jue sep 30 16:38:11 -0400 2010: > When I read the description of the algorithm, I can't imagine a > situation where --patience would make the diff *worse*. I was > somewhat afraid (based on the name) that it would be slow; but > if it is slower, it hasn't

Re: [HACKERS] git diff --patience

2010-09-30 Thread Kevin Grittner
Gurjeet Singh wrote: > The with-patience version has only two hunks, removal of a big > block of comment and addition of a big block of code. > > The without-patience patience is riddled with the mix of two > hunks, spread until line 120. > > --patience is a clear winner here. When I read th

Re: [HACKERS] git diff --patience

2010-09-30 Thread Gurjeet Singh
Attached are two versions of the same patch, with and without --patience. The with-patience version has only two hunks, removal of a big block of comment and addition of a big block of code. The without-patience patience is riddled with the mix of two hunks, spread until line 120. --patience is

Re: [HACKERS] git diff --patience

2010-09-29 Thread Kevin Grittner
Peter Eisentraut wrote: > Do you have an existing commit where you see a difference so I can > try it and see if there is some other problem that my local > configuration has? Random poking around in the postgresql.git commits didn't turn up any where it mattered, so here's before and after fi

Re: [HACKERS] git diff --patience

2010-09-29 Thread Kevin Grittner
Peter Eisentraut wrote: > I have tried this switch various times now and haven't seen any > difference at all in the output. Do you have an existing commit > where you see a difference so I can try it and see if there is > some other problem that my local configuration has? Having looked at i

Re: [HACKERS] git diff --patience

2010-09-29 Thread Peter Eisentraut
On ons, 2010-09-15 at 12:58 -0500, Kevin Grittner wrote: > I just discovered the --patience flag on the git diff command, and > I'd like to suggest that we encourage people to use it when possible > for building patches. I just looked at output with and without it > (and for good measure, before a

Re: [HACKERS] git diff --patience

2010-09-16 Thread Bruce Momjian
Kevin Grittner wrote: > I just discovered the --patience flag on the git diff command, and > I'd like to suggest that we encourage people to use it when possible > for building patches. I just looked at output with and without it > (and for good measure, before and after filterdiff --format=contex

[HACKERS] git diff --patience

2010-09-15 Thread Kevin Grittner
I just discovered the --patience flag on the git diff command, and I'd like to suggest that we encourage people to use it when possible for building patches. I just looked at output with and without it (and for good measure, before and after filterdiff --format=context for both), and the results w