Re: [HACKERS] heap_freeze_tuple locking requirements

2012-03-26 Thread Robert Haas
On Fri, Mar 23, 2012 at 11:02 AM, Alvaro Herrera wrote: > Excerpts from Robert Haas's message of mié mar 21 21:50:24 -0300 2012: >> heap_freeze_tuple() was apparently designed at one point to cope with >> being called with either a shared or exclusive buffer lock.  But none >> of the current calle

Re: [HACKERS] heap_freeze_tuple locking requirements

2012-03-23 Thread Alvaro Herrera
Excerpts from Robert Haas's message of mié mar 21 21:50:24 -0300 2012: > heap_freeze_tuple() was apparently designed at one point to cope with > being called with either a shared or exclusive buffer lock. But none > of the current callers call it with a shared lock; they all call it > with an exc

[HACKERS] heap_freeze_tuple locking requirements

2012-03-21 Thread Robert Haas
heap_freeze_tuple() was apparently designed at one point to cope with being called with either a shared or exclusive buffer lock. But none of the current callers call it with a shared lock; they all call it with an exclusive lock, except for the heap-rewrite code which doesn't take (or need) a loc