Re: [HACKERS] improving on pgrminclude / pgcompinclude ?

2016-10-05 Thread Robert Haas
On Wed, Oct 5, 2016 at 12:28 PM, Tom Lane wrote: > Robert Haas writes: >> I wonder if we can do better. The attached patch is the rest of a >> couple of hours of hacking on a "see whether all of our includes >> compile separately" project. Directions: > > Don't we have more or less that already

Re: [HACKERS] improving on pgrminclude / pgcompinclude ?

2016-10-05 Thread Tom Lane
Robert Haas writes: > I wonder if we can do better. The attached patch is the rest of a > couple of hours of hacking on a "see whether all of our includes > compile separately" project. Directions: Don't we have more or less that already in src/tools/pginclude/cpluspluscheck? > It strikes me t

[HACKERS] improving on pgrminclude / pgcompinclude ?

2016-10-05 Thread Robert Haas
Amit's complaint about unnecessary headers got me thinking about src/tools/pginclude. I think the the stuff in this directory is trying to do something useful, because I think extra #include directives that we don't need are a useful thing to eliminate. However, in practice the contents are very h