Re: [HACKERS] improving speed of make check-world

2015-04-28 Thread Peter Eisentraut
On 4/28/15 9:09 AM, Michael Paquier wrote: I guess by redirecting it into the log file you indicated, but is that a good idea to redirect stderr? I am sure that Peter did that on purpose, both approaches having advantages and disadvantages. Personally I don't mind looking at the install log

Re: [HACKERS] improving speed of make check-world

2015-04-28 Thread Tom Lane
Michael Paquier michael.paqu...@gmail.com writes: On Tue, Apr 28, 2015 at 1:46 AM, Jeff Janes jeff.ja...@gmail.com wrote: This change fixed the problem for me. It also made this age-old compiler warning go away: In file included from gram.y:14515: scan.c: In function 'yy_try_NUL_trans':

Re: [HACKERS] improving speed of make check-world

2015-04-27 Thread Jeff Janes
On Sat, Apr 25, 2015 at 7:23 AM, Michael Paquier michael.paqu...@gmail.com wrote: On Sat, Apr 25, 2015 at 7:59 AM, Peter Eisentraut pete...@gmx.net wrote: On 4/23/15 1:22 PM, Jeff Janes wrote: Something about this commit (dcae5faccab64776376d354d) broke make check in parallel conditions

Re: [HACKERS] improving speed of make check-world

2015-04-25 Thread Michael Paquier
On Sat, Apr 25, 2015 at 7:59 AM, Peter Eisentraut pete...@gmx.net wrote: On 4/23/15 1:22 PM, Jeff Janes wrote: Something about this commit (dcae5faccab64776376d354d) broke make check in parallel conditions when started from a clean directory. It fails with a different error each time, one

Re: [HACKERS] improving speed of make check-world

2015-04-24 Thread Peter Eisentraut
On 4/23/15 1:22 PM, Jeff Janes wrote: Something about this commit (dcae5faccab64776376d354d) broke make check in parallel conditions when started from a clean directory. It fails with a different error each time, one example: make -j4 check /dev/null In file included from gram.y:14515:

Re: [HACKERS] improving speed of make check-world

2015-04-23 Thread Jeff Janes
On Thu, Aug 14, 2014 at 10:45 PM, Peter Eisentraut pete...@gmx.net wrote: make check-world creates a temporary installation in every subdirectory it runs a test in, which is stupid: it's very slow and uses a lot of disk space. It's enough to do this once per run. That is the essence of what

Re: [HACKERS] improving speed of make check-world

2015-04-11 Thread Michael Paquier
On Sat, Apr 11, 2015 at 4:35 AM, Peter Eisentraut pete...@gmx.net wrote: On 3/9/15 2:51 AM, Michael Paquier wrote: On Sun, Mar 8, 2015 at 10:46 PM, Michael Paquier michael.paqu...@gmail.com wrote: Speaking of which, attached is a patch rewritten in-line with those comments, simplifying a bit

Re: [HACKERS] improving speed of make check-world

2015-04-11 Thread Michael Paquier
On Sat, Apr 11, 2015 at 8:48 PM, Michael Paquier wrote: Now, what this patch does is enforcing the temporary install for each *check target of vcregress.pl. This has the disadvantage of making the benefits of MAKELEVEL=0 seen for build methods using the Makefiles go away for MSVC A trick that

Re: [HACKERS] improving speed of make check-world

2015-03-09 Thread Michael Paquier
On Sun, Mar 8, 2015 at 10:46 PM, Michael Paquier michael.paqu...@gmail.com wrote: Speaking of which, attached is a patch rewritten in-line with those comments, simplifying a bit the whole at the same time. Note this patch changes ecpgcheck as it should be patched, but as ecpgcheck test is

Re: [HACKERS] improving speed of make check-world

2015-03-08 Thread Michael Paquier
On Sun, Mar 8, 2015 at 10:22 PM, Peter Eisentraut pete...@gmx.net wrote: On 2/24/15 3:06 AM, Michael Paquier wrote: On Sun, Feb 15, 2015 at 11:01 AM, Peter Eisentraut wrote: Here is an updated patch. Nice patch. This is going to save a lot of resources. An update of vcregress.pl is

Re: [HACKERS] improving speed of make check-world

2015-03-08 Thread Peter Eisentraut
On 2/24/15 3:06 AM, Michael Paquier wrote: On Sun, Feb 15, 2015 at 11:01 AM, Peter Eisentraut wrote: Here is an updated patch. Nice patch. This is going to save a lot of resources. An update of vcregress.pl is necessary. This visibly just consists in updating the options that have been

Re: [HACKERS] improving speed of make check-world

2015-02-14 Thread Peter Eisentraut
On 8/31/14 5:36 AM, Fabien COELHO wrote: Running make -j2 check-world does not work because initdb is not found by pg_regress. but make -j1 check-world does work fine. It seems that some dependencies might be missing and there is a race condition between temporary install and running some

Re: [HACKERS] improving speed of make check-world

2015-02-14 Thread Tom Lane
Peter Eisentraut pete...@gmx.net writes: On 8/31/14 5:36 AM, Fabien COELHO wrote: Running make -j2 check-world does not work because initdb is not found by pg_regress. but make -j1 check-world does work fine. It seems that some dependencies might be missing and there is a race condition

Re: [HACKERS] improving speed of make check-world

2014-08-31 Thread Fabien COELHO
Hello Peter, Here is a review: The version 2 of the patch applies cleanly on current head. The ability to generate and reuse a temporary installation for different tests looks quite useful, thus putting install out of pg_regress and in make seems reasonnable. However I'm wondering

Re: [HACKERS] improving speed of make check-world

2014-08-31 Thread Fabien COELHO
# actual new tmp installation .tmp_install: $(RM) ./.tmp_install.* $(RM) -r ./tmp_install # create tmp installation... touch $@ # tmp installation for the nonce .tmp_install.$(MAKE_NONCE): .tmp_install touch $@ Oops, I got it wrong, the install

Re: [HACKERS] improving speed of make check-world

2014-08-30 Thread Peter Eisentraut
Updated, rebased patch. diff --git a/.gitignore b/.gitignore index 681af08..823d3ac 100644 --- a/.gitignore +++ b/.gitignore @@ -34,3 +34,4 @@ lib*.pc /pgsql.sln.cache /Debug/ /Release/ +/tmp_install/ diff --git a/GNUmakefile.in b/GNUmakefile.in index 69e0824..5667943 100644 ---

Re: [HACKERS] improving speed of make check-world

2014-08-25 Thread Heikki Linnakangas
On 08/15/2014 08:45 AM, Peter Eisentraut wrote: make check-world creates a temporary installation in every subdirectory it runs a test in, which is stupid: it's very slow and uses a lot of disk space. It's enough to do this once per run. That is the essence of what I have implemented. It cuts

Re: [HACKERS] improving speed of make check-world

2014-08-25 Thread Peter Eisentraut
On 8/25/14 1:32 PM, Heikki Linnakangas wrote: The new EXTRA_INSTALL makefile variable ought to be documented in extend.sgml, where we list REGRESS_OPTS and others. But EXTRA_INSTALL is only of use inside the main source tree, not by extensions. -- Sent via pgsql-hackers mailing list

[HACKERS] improving speed of make check-world

2014-08-14 Thread Peter Eisentraut
make check-world creates a temporary installation in every subdirectory it runs a test in, which is stupid: it's very slow and uses a lot of disk space. It's enough to do this once per run. That is the essence of what I have implemented. It cuts the time for make check-world in half or less,